cmake: revert visibility modification to just sloth

NOAA-OWP · Jan 3, 2024 · d26fd1c · d26fd1c
1 parent 1fe7fc9
commit d26fd1c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -181,6 +181,7 @@ if(NGEN_WITH_EXTERN_SLOTH)
         GIT_UPDATE "${NGEN_EXT_DIR}/sloth"
         IMPORTS    slothmodel
     )
+    set_target_properties(slothmodel PROPERTIES CXX_VISIBILITY_PRESET default)
 endif()
 
 # -----------------------------------------------------------------------------

diff --git a/cmake/ExternalSubdirectory.cmake b/cmake/ExternalSubdirectory.cmake
@@ -20,11 +20,7 @@ function(add_external_subdirectory)
     endif()
 
     if(EXTERNAL_TARGET_IMPORTS STREQUAL "")
-        if(TARGET ${EXTERNAL_TARGET_IMPORTS})
-            set_target_properties(${EXTERNAL_TARGET_IMPORTS}
-                PROPERTIES
-                    CXX_VISIBILITY_PRESET default)
-        else()
+        if(NOT TARGET ${EXTERNAL_TARGET_IMPORTS})
             message(FATAL_ERROR "Target `${EXTERNAL_TARGET_IMPORTS}` could not be found from subdirectory ${EXTERNAL_TARGET_SOURCE}")
         endif()
     endif()