Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmor and logging and yaml #326

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Cmor and logging and yaml #326

wants to merge 7 commits into from

Conversation

ilaflott
Copy link
Member

@ilaflott ilaflott commented Jan 17, 2025

Describe your changes

  • new configuration options in pytest.ini to play with, commented out by default- seems like the pipeline doesn't like it but locally it's nice to leverage
  • fre/fre.py now gets and sets a root level logger's logging.basicConfig level, and format
  • adds -v/--verbose flag to base fre command group
  • adds -l/--log_file flag to base fre command group, sets log file path for output. None for stdout/stderr to print to screen as usual
  • adds --no_wait option (skips cylc scan scheduler check) option to fre pp run
  • adds --pause (maps to cylc play --pause) option to fre pp run
  • replaces all print calls in fre.cmor with fre_logger calls to either info, warning, and (one instance) error

Issue ticket number and link (if applicable)

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback

….py. add single logger.info line inlieu of print statement for commit + push to github for init CI/CD attempt
…nd give new log_file argument. remove needlless space at the beginning of most current logging statements (that were print statements).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant