Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

223.fre make makefile test #248

Merged
merged 12 commits into from
Nov 5, 2024
Merged

223.fre make makefile test #248

merged 12 commits into from
Nov 5, 2024

Conversation

singhd789
Copy link
Collaborator

@singhd789 singhd789 commented Nov 4, 2024

Describe your changes

Issue ticket number and link (if applicable)

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback

@singhd789 singhd789 marked this pull request as ready for review November 4, 2024 19:21
@singhd789
Copy link
Collaborator Author

NOTE: the tests for create-makefile are not done done, but I wanted to get the other edits in and the initial test started

@ilaflott
Copy link
Member

ilaflott commented Nov 5, 2024

looks great!

@ilaflott ilaflott merged commit c9ef8f5 into main Nov 5, 2024
2 checks passed
@ilaflott ilaflott deleted the 223.fre-make-makefile-test branch November 5, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants