Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmor bite wrapup #237

Merged
14 commits merged into from
Nov 1, 2024
Merged

Cmor bite wrapup #237

14 commits merged into from
Nov 1, 2024

Conversation

ilaflott
Copy link
Member

going to follow up on #218 here

  • 4. atmos gr1 / Amon / ta
    • allow no-lon coordinate axis case
  • 6. ocean gn / Omon / sos
    • nc_copy bug
  • 7. ocean gr / Omon / so (three dimensional ocean)
    • nc_copy bug
  • 8. atmos gn / Amon / ch4global
    • allow no-lon coordinate axis case
    • allow no-lat coordinate axis case
  • 9. LUmip gr1 Emon / gppLut
    • come up with an edge-case work around for non-typical coordinate in place of a more typical vertical coordinate

Code QA:

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback

This PR adds...

ilaflott and others added 14 commits October 24, 2024 13:10
…in new optional argument for additional control over file targeting. we also now have a \"run one file only\" style flag. new test config file fre/tests/test_files/CMORbite_var_list.json contains variables for processing test cases being workd through in run_test_file_cases.py with notes
…e code currently relies on. unsure how useful the exact way i wrote things down is, but im hoping ot leverage it for structure and or setting up some formulaic approaches and or rules. additionally, merge multiline printstateaments into one call using legal but maybe awkward looking multiline syntax, some other readability edits too
…e file, see how it goes..."

This reverts commit 4b31338.
…tions at the cli. update test file cases for addressing no lat/lon case(s)
… checks, trying to generally allow this code to be more flexible. not currently working atm
@ilaflott ilaflott added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request tricky Likely to encounter significant friction to solution priority: HIGH labels Oct 31, 2024
@ilaflott ilaflott self-assigned this Oct 31, 2024
@ilaflott ilaflott marked this pull request as draft October 31, 2024 19:26
@ilaflott ilaflott mentioned this pull request Oct 31, 2024
22 tasks
@ilaflott ilaflott closed this pull request by merging all changes into main in 16af470 Nov 1, 2024
@ilaflott ilaflott deleted the cmor-bite-wrapup branch November 1, 2024 16:42
@ilaflott ilaflott restored the cmor-bite-wrapup branch November 1, 2024 17:11
@ilaflott
Copy link
Member Author

ilaflott commented Nov 1, 2024

EXCEEDINGLY confused- this must have "been merged" since PR #218 included a revert to a commit in this branch that i wanted to continue working with...

@ilaflott ilaflott deleted the cmor-bite-wrapup branch November 1, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request priority: HIGH tricky Likely to encounter significant friction to solution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant