Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

230.Add decorator functions to pass click options correctly #231

Merged
merged 5 commits into from
Oct 31, 2024

Conversation

singhd789
Copy link
Collaborator

  • this was needed in order to import fre make scripts successfully when creating pytests

Describe your changes

Issue ticket number and link (if applicable)

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback

- this was needed in order to import fre make scripts successfully when creating pytests
fre/make/createCompile.py Outdated Show resolved Hide resolved
fre/make/createDocker.py Outdated Show resolved Hide resolved
Copy link
Member

@ilaflott ilaflott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

underscore convention is backwards!

@singhd789
Copy link
Collaborator Author

underscore convention is backwards!

@ilaflott Hmmm so when I reverse the underscore convention, I keep getting this:

TypeError: Callback is not a command.

@ilaflott
Copy link
Member

underscore convention is backwards!

@ilaflott Hmmm so when I reverse the underscore convention, I keep getting this:

TypeError: Callback is not a command.

since it changes a module name, you need to change the name in other places where that old name is imported, is my guess.

this pattern is absolutely doable, most every other subtool currently has it

@ilaflott
Copy link
Member

ilaflott commented Oct 30, 2024

underscore convention is backwards!

@ilaflott Hmmm so when I reverse the underscore convention, I keep getting this:

TypeError: Callback is not a command.

since it changes a module name, you need to change the name in other places where that old name is imported, is my guess.

this pattern is absolutely doable, most every other subtool currently has it

let me note that fre pp checkout also has the pattern backwards... i.e. i'll get on others case about it!

@singhd789
Copy link
Collaborator Author

singhd789 commented Oct 30, 2024

let me note that fre pp checkout also has the pattern backwards... i.e. i'll get on others case about it!

I think I may have done it with fre pp configure-yaml ... as well. 😅

I see it done for most of the fre pp tools

@ilaflott ilaflott merged commit 16612d5 into main Oct 31, 2024
2 checks passed
@ilaflott ilaflott deleted the 230.fix-click-decorators branch October 31, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants