Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#212 Make compile and checkout scripts executable #220

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

singhd789
Copy link
Collaborator

  • make scripts executable after creating
  • moved chmod lines earlier in scripts

Describe your changes

Issue ticket number and link (if applicable)

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback

- make scripts executable after creating
- moved `chmod` lines earlier in scripts
@ilaflott
Copy link
Member

@ceblanton @thomas-robinson can someone make @laurenchilutti s reviews offish?

@ilaflott ilaflott merged commit 65fc0c2 into main Oct 28, 2024
2 checks passed
@ilaflott ilaflott deleted the 212.make-scripts-executable branch October 28, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fre make generated scripts do not have executable permissions
3 participants