This is the code update for calling new Icepack. #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "main" branch as of Oct 24, 2024 adds the optional arguments described here. It uses the public icepack_step_ridge instead of the old interface, which is now private. The code that was in Icepack's ridge_prep had to be moved to the SIS2 side. There are two new options in the call to icepack_step_ridge, telling it how much to do. To reproduce old answers, both options should be set to False. On the Icepack side, they recommend both being True, which will not only call the ridging code, but also put a limiter on some ice fields (no negative thicknesses, etc.) and call the rebin routine, which resets which ice is in which thickness category. All three versions run for me (three because rebin depends on calling the cleanup routine). I have promised some feedback if we later decide to just pick one forever.
|
Icepack 1.5.0 has been released with this note: |
|
Thanks for your efforts Kate! We will test the various options.
On Tuesday, November 19, 2024, Kate Hedstrom ***@***.***> wrote:
Icepack 1.5.0 has been released with this note:
NOTE: This version is not backwards compatible with earlier versions of
Icepack due to changes in public interfaces. In addition, all answers are
changed.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.<
…--
Matthew Harrison (he/him)
USDOC/NOAA/GFDL/Oceans&Cryosphere
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "main" branch as of Oct 24, 2024 adds the optional arguments
described here.
It uses the public icepack_step_ridge instead of the old interface,
which is now private. The code that was in Icepack's ridge_prep had
to be moved to the SIS2 side. There are two new options in the call to
icepack_step_ridge, telling it how much to do. To reproduce old answers,
both options should be set to False. On the Icepack side, they recommend
both being True, which will not only call the ridging code, but also put
a limiter on some ice fields (no negative thicknesses, etc.) and call
the rebin routine, which resets which ice is in which thickness category.
All three versions run for me (three because rebin depends on calling
the cleanup routine). I have promised some feedback if we later decide
to just pick one forever.