Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FMS 2023.03 contains mixed precision support and had modified the types of sst_ncep and sst_anom to be hard-coded real8 in amip_interp_mod, which would have required updating some code in this repository when we reference sst_ncep and sst_anom in subroutines (such as pmaxmin).
In testing this tag of FMS, we noticed that these variables do not need to come from amip_interp_mod as we allocate them within the dycore. FMS will be updated to no longer declare sst_ncep and sst_anom(see issue: NOAA-GFDL/FMS#1393), and this PR fixes the use statement so that we do not use the amip_interp_mod sst_ncep and sst_anom. We also removed the
#ifdef NO_GFDL_SHARED
as this is not needed as we will always be compiling the sycore with FMS.Fixes # (issue)
How Has This Been Tested?
Tested with FMS2023.03 with the SHiELD CI and RTS tests
Checklist:
Please check all whether they apply or not