Added save attribute to Host Associated Arrays #1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrooks1085
requested review from
uramirez8707,
bensonr and
rem1776
as code owners
laurenchilutti
approved these changes
Oct 24, 2024
uramirez8707
approved these changes
Oct 24, 2024
rem1776
requested changes
Oct 24, 2024
| character(100) :: cline1, cline2, cline3, cline4, cline5, clin6 | ||
|
|
||
| !> read in computed values | ||
| open(newunit=iunit, file=di_file) | ||
| open(unit=iunit,file=trim(di_file)) |
There was a problem hiding this comment.
This should be changed back to using newunit rather than a hardcoded unit number. It's typically a better practice and I think this would also break the test with cray since it reserves 100 for stdin.
There was a problem hiding this comment.
Andrew just needs to merge in the main branch - he made these changes before Jesse's newunit fix got merged in so now it shows as Andrew changing it back
There was a problem hiding this comment.
Yes, Lauren is correct. I'll fix it
|
Same question as @rem1776. |
|
Can you rewrite this test to pass the arrays into the subroutines rather than keep them as program level variables? From our group discussions, this seems to be agreed upon as a path forward with this unit test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds save attribute to host associated arrays in test_topography and test_diag_integral so that these tests now pass with the ifx compiler.
How Has This Been Tested?
The Topography and Diag_integral unit tests successfully build and pass using the Intel oneAPI 2024.2 IFX compiler on an AMD box.
Checklist:
make distcheckpasses