Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix r8/r4 configure checks with intel -warn flag #1583

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

rem1776
Copy link
Contributor

@rem1776 rem1776 commented Sep 3, 2024

Description
When compiling with intel the -warn flag breaks the m4 check that looks for real default kind flags. During ./configure when it uses the correct kind default flags with -warn, it gets an error stating There is a conflict between local interface block and external interface block..

This modifies the check to remove the interface block and just use a contains for the subroutine, this way it won't fail on what seems to be a unrelated error.

How Has This Been Tested?
ifort (oneapi 2024.2) with the mkmf debug flags on amd

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@rem1776 rem1776 merged commit 3401f60 into NOAA-GFDL:main Oct 9, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants