Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cray mod output check and unused newunit macro to configure script #1561

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

rem1776
Copy link
Contributor

@rem1776 rem1776 commented Jul 26, 2024

Description
@J-Lentz found that the cray compiler capitalizes .mod files by default which causes some issues with the build. This PR adds a m4 macro to check if that behavior is happening and if so adds a flag -ef to disable it.

There was also an unused m4 file that checks for if a compiler supports newunit in open calls, from what i can see in the history it seems like it may have just accidentally never been added to the configure.ac file at the time it was added to the repo. This adds the call so it can actually run as well and also adds a line to remove a leftover file from one of the checks.

How Has This Been Tested?
tested with intel, gcc, and the cray compiler on gaea and also with intel and gcc on the amd box

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@rem1776 rem1776 requested a review from uramirez8707 as a code owner July 26, 2024 19:24
@rem1776 rem1776 merged commit 4fcc421 into NOAA-GFDL:main Aug 29, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants