Data override ext weights #1556
Conversation
…external weights from file Added components ext_weights_file_name and ext_weights_source to the derived type data_type
…ttempting to read the 'type' key value
…S into Data_Override_Ext_Weights
uramirez8707
requested review from
rem1776,
thomas-robinson and
bensonr
as code owners
data_override/README.MD
Outdated
| - **next_file_name:** The name of the third file in the set | ||
| - **external_weights:** The external weights parent key. **Required** only if it is desired to use external weights from file | ||
| - **file_name:** Name of the file where the external weights are located, including the directory | ||
| - **source:** Name of the source that generated the external weights. The acceptable values are "esmf" and "fregrid" |
There was a problem hiding this comment.
Are we supporting ESMF weight files? I had put in PR#1399 that we were only supporting fregrid-generated.
There was a problem hiding this comment.
I updated the documentation
data_override/README.MD
Outdated
| - **multi_file:** The multifile parent key. **Required** only if it is desired to use multiple(3) input netcdf files instead of 1. Note that **file_name** must be the second file in the set when using multiple input netcdf files | ||
| - **prev_file_name:** The name of the first file in the set | ||
| - **next_file_name:** The name of the third file in the set | ||
| - **external_weights:** The external weights parent key. **Required** only if it is desired to use external weights from file |
There was a problem hiding this comment.
I noticed the only supported method for external weights is bilinear. Is the interp_method used in conjunction with the external_weights to determine the method?
It seems we may be opening things up to undetermined behavior using the interp_method in conjunction with the external_weights. Is there a method or some other global attribute in the file we could use to compare against the chosen interp_method?
There was a problem hiding this comment.
Is there a method or some other global attribute in the file we could use to compare against the chosen interp_method
The only thing that we currently do is check that the weight file has the expected dimensions for the interp method. It can be done more rigorous though.
data_override/README.MD
Outdated
| - **interpol_method:** Method used to interpolate the field. The acceptable values are "bilinear", "bicubic", and "none". "none" implies that the field in the file is already in the model grid. The LIMA format is no longer supported. **Required** only if overriding from a file | ||
| - **grid_name:** Name of the grid to interpolate the data to. The acceptable values are "ICE", "OCN", "ATM", and "LND" | ||
| - **fieldname_in_model:** Name of the field as it is in the code to interpolate. | ||
| - **override_file:** The parent key containing the nested keys related to overriding data from file. **Required** only if overriding from a file |
There was a problem hiding this comment.
Concerned the use of parent and nested keys here could be confused with the idea of parent and nested grids. Is the standardized YAML terminology to use parent and nest or can we define it as we want?
There was a problem hiding this comment.
@uramirez8707 - appreciate you changing the language according to my suggestions.
Description
This PR takes in #1534 and makes the changes needed to data_override and horiz_interp to read in the weight files and fill in the horiz_interp type
Currently, this has only been implemented for bilinear.
Fixes #1399
How Has This Been Tested?
CI, including new test
Checklist:
make distcheckpasses