Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modern diag_manager: Simplify the diag table yaml #1545

Merged
merged 4 commits into from
Aug 1, 2024

Conversation

uramirez8707
Copy link
Contributor

@uramirez8707 uramirez8707 commented Jun 12, 2024

Description
This simplifies the diag table yaml by allowing the module, reduction and kind to be set at a file level, with the ability to override them at a field level.

This is backwards compatible as the old diag table yaml formats should still work.

Fixes #1542
How Has This Been Tested?
CI, including added test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

…uction can be specified at te file level with the option to override at the variable level
@thomas-robinson
Copy link
Member

Is there an update to the schema?

diag_manager/diag_yaml_format.md Outdated Show resolved Hide resolved
@uramirez8707
Copy link
Contributor Author

Is there an update to the schema?

@thomas-robinson NOAA-GFDL/gfdl_msd_schemas#3

@rem1776 rem1776 merged commit 43def16 into NOAA-GFDL:main Aug 1, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modern diag manager :: Simplify the diag table yaml format
3 participants