Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove diag table schema #1543

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Remove diag table schema #1543

merged 1 commit into from
Jul 17, 2024

Conversation

J-Lentz
Copy link
Contributor

@J-Lentz J-Lentz commented Jun 7, 2024

Description
Remove the diag table schema, as it has been moved to the gfdl_msd_schemas repository. Add references to the schema and the new repository to the diag manager's README.md and diag_yaml_format.md files.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

Remove the diag table schema, as it has been moved to the
`gfdl_msd_schemas` repository. Add references to the schema and the new
repository to the diag manager's `README.md` and `diag_yaml_format.md`
files.
Copy link
Contributor

@uramirez8707 uramirez8707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me

@rem1776 rem1776 merged commit 77382e3 into NOAA-GFDL:main Jul 17, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants