Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flag in intel ci workflow #1541

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Conversation

rem1776
Copy link
Contributor

@rem1776 rem1776 commented Jun 5, 2024

Description
This fixes a mistake in one of the flags in the intel CI where it was added as a compiler flag rather than a configure option.

It seems the storage issues we were encountering went away at some point, but before they went away a hdf5 check in the configure script was added, which started causing failures since the LD_LIBRARY_PATH needed to be set again for the configure script.

How Has This Been Tested?
CI

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@rem1776 rem1776 marked this pull request as draft June 6, 2024 13:23
@rem1776 rem1776 marked this pull request as ready for review June 6, 2024 14:01
@rem1776 rem1776 merged commit e81d5b1 into NOAA-GFDL:main Jun 11, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants