set is_allocated in all horiz_interp_type_new routines #1538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-robinson
requested changes
Jun 24, 2024
Comment on lines
987
to
989
| !! for bicubic set up | ||
| real(HI_TEST_KIND_), allocatable :: lon_src_1d(:), lat_src_1d(:) | ||
| real(HI_TEST_KIND_), allocatable :: lon_dst_1d(:), lat_dst_1d(:) |
There was a problem hiding this comment.
These should have doxygen documentation instead of just a comment above
bensonr
reviewed
Jun 25, 2024
| @@ -36,7 +36,7 @@ module horiz_interp_spherical_mod | |||
| use fms_mod, only : write_version_number | |||
| use fms_mod, only : check_nml_error | |||
| use constants_mod, only : pi | |||
| use horiz_interp_type_mod, only : horiz_interp_type, stats | |||
| use horiz_interp_type_mod, only : horiz_interp_type, stats, SPHERICA | |||
There was a problem hiding this comment.
Is there a reason we do not include the trailing L other than to limit the variable name to 8 characters?
There was a problem hiding this comment.
No as far as I can tell that's the only reason it's cut off. I checked if there was anything else used in FMS named spherical but there's not.
Should we update it to add the L?
…d parameters from libFMS.F90
|
@thomas-robinson @bensonr This should be ready now, I updated the SPHERICA to SPHERICAL. I noticed that the interpolation method values were made public in the libFMS.F90 file so I also removed them from there as well since they should only be internal. |
bensonr
approved these changes
Jun 27, 2024
thomas-robinson
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sets the
is_allocatedfield as well as themethod_typewithin horiz_interp_types when called from any of the method specific horiz_interp_new routines. This should prevent reallocation errors as described in the issue below.Also adds some calls to the unit test to test this functionality and renames one of the CPP macros to make more sense.
Fixes #1533
How Has This Been Tested?
make distcheck with oneapi 2024.01 on amd box
Checklist:
make distcheckpasses