Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cmake debug build #1532

Merged
merged 2 commits into from
Jun 21, 2024
Merged

fix cmake debug build #1532

merged 2 commits into from
Jun 21, 2024

Conversation

rem1776
Copy link
Contributor

@rem1776 rem1776 commented May 22, 2024

Description
#971 made some changes so that the debug build wouldn't set some default flags (in favor of setting the flags manually). This was useful for testing the build but is non-standard and not a good idea, so this removes all of those changes.

Also updates the CI to use both build types in order to catch this error.

Fixes #1531

How Has This Been Tested?
built with gcc 13 and latest oneapi on amd box

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@rem1776 rem1776 merged commit 98ea776 into NOAA-GFDL:main Jun 21, 2024
26 of 28 checks passed
JustinPerket pushed a commit to JustinPerket/FMS that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build Error with GNU + fms_r8 + Debug Flags
2 participants