Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add root pe number to diag_field_log filename #1497

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

rem1776
Copy link
Contributor

@rem1776 rem1776 commented Apr 24, 2024

Description
adds the root pe number to the filename of the the diag_field_log.out. When running SPEAR it seems like mom was writing from a different root pe and overwriting the file, so this avoids that by writing out distinct filenames.
Fixes #1496

How Has This Been Tested?
tested with the spear regressions, intel23-classic

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

Copy link
Contributor

@bensonr bensonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still opportunities for race conditions of two MPI-ranks writing to this file at the same time. I think we'd be better off using the same approach as logfile.out and appending the root_pe number to the file to make them unique.

@rem1776 rem1776 changed the title add file check for diag_field_log before opening add root pe number to diag_field_log filename Apr 25, 2024
@rem1776 rem1776 marked this pull request as ready for review April 25, 2024 15:54
@rem1776 rem1776 merged commit 7d565db into NOAA-GFDL:main Jun 24, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing registered fields in diag_field_log.out
3 participants