Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modern_diag_manager:: send data 4d #1402

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Modern_diag_manager:: send data 4d #1402

merged 3 commits into from
Nov 20, 2023

Conversation

uramirez8707
Copy link
Contributor

@uramirez8707 uramirez8707 commented Nov 2, 2023 •
edited
Loading

Description
Add send_data_4d (x,y,z,?)
Update tests to test the new interface

Fixes #747

How Has This Been Tested?
CI including updated tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@thomas-robinson thomas-robinson merged commit 26aa42f into NOAA-GFDL:dmUpdate Nov 20, 2023
17 of 18 checks passed
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
@uramirez8707
Modern_diag_manager:: send data 4d (NOAA-GFDL#1402)
3f33fa6 
* Add send_data_4d, update tests to test the new interface
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
@uramirez8707
feat: Modern_diag_manager add send_data_4d (NOAA-GFDL#1402)
45cf5ee
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
@uramirez8707
Modern_diag_manager:: send data 4d (NOAA-GFDL#1402)
15626f9 
* Add send_data_4d, update tests to test the new interface
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
@uramirez8707
feat: Modern_diag_manager add send data 4d (NOAA-GFDL#1402)
e03aa91
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
@uramirez8707
feat: Modern_diag_manager add send data 4d (NOAA-GFDL#1402)
6335ec7
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
@uramirez8707
feat: Modern_diag_manager add send data 4d (NOAA-GFDL#1402)
532c4b2
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
@uramirez8707
feat: Modern_diag_manager add send data 4d (NOAA-GFDL#1402)
f6816c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rem1776 rem1776 rem1776 approved these changes

@thomas-robinson thomas-robinson thomas-robinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uramirez8707 @thomas-robinson @rem1776