modern_diag_manager: Update output_buffer_obj #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r routine to match the old diag manager, adjust tests, add a flag that indicates when done writing data to the diag_file, set output buffers to fill value if masked
…e-inits of the buffer to when after writing
uramirez8707
force-pushed
the
add_time_counters
branch
from
866f796
to
011b414
Compare
| @@ -67,6 +67,7 @@ module fms_diag_file_object_mod | |||
| TYPE(time_type) :: next_output !< Time of the next write | |||
| TYPE(time_type) :: next_next_output !< Time of the next next write | |||
| TYPE(time_type) :: no_more_data !< Time to stop receiving data for this file | |||
| logical :: done_writing_data!< .True. if finished writing data | |||
There was a problem hiding this comment.
finished writing data for the time step? It's a little unclear to me what point of the process this gets turned to true. Maybe data_written_for_timestep would be more descriptive if that's the intent.
There was a problem hiding this comment.
This is for the diag file object.
I think there are two cases where this will be set to true:
- Static files after the first write
- Files that are using the
file_durationfunctionality in the yaml file
There was a problem hiding this comment.
Can you add that to the documentation
|
|
||
| !TODO mostly everything | ||
| field_ptr => this%FMS_diag_fields(diag_field_id) | ||
| if (field_ptr%has_missing_value()) then | ||
| select type (missing_val => field_ptr%get_missing_value(r8)) | ||
| type is (real(kind=r8_kind)) |
| end function is_done_with_math | ||
|
|
||
| !> @brief Set done_with_math to .true. | ||
| subroutine set_done_with_math(this) |
There was a problem hiding this comment.
How do you set it to false? I think this should take a logical argument so you can set it to true or false.
There was a problem hiding this comment.
I don't think you will you ever set it back to .false.
This will be set to .true. for variables that are static after the "math" (a copy) is done for the first time.
rem1776
approved these changes
Sep 7, 2023
thomas-robinson
approved these changes
Sep 8, 2023
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
* Add some needed members to the buffer obj, restructure the init_buffer routine to match the old diag manager, adjust tests, add a flag that indicates when done writing data to the diag_file, set output buffers to fill value if masked * inits done_with_math
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
* Add some needed members to the buffer obj, restructure the init_buffer routine to match the old diag manager, adjust tests, add a flag that indicates when done writing data to the diag_file, set output buffers to fill value if masked * inits done_with_math
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MIN_VALUEfortime_min,MAX_VALUEfortime_maxandEMPTYfor others (instead of the missing_value). This is needed for the reduction methods to work correctly (i.e when averaging you are simply adding the input data to the output buffer so if it is the output buffer is initialized to the missing value it won't be correct. The tests were updated to account for this change.do_time_none_wrapperanddo_time_nonefunctions so that they take in the missing value. Data points that are masked will be set to this.done_writing_datato the diag_file object. This will be used for static files after the first write and for files that are using thefile_durationfunctionality.Fixes # (issue)
How Has This Been Tested?
CI
Checklist:
make distcheckpasses