Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes variables named data to other variable names #1351

Closed
wants to merge 45 commits into from
Closed

Changes variables named data to other variable names #1351

wants to merge 45 commits into from

Conversation

mcallic2
Copy link
Contributor

@mcallic2 mcallic2 commented Aug 23, 2023 •
edited
Loading

Description
data was introduced as a "data statement" in fortran 77. It can be used to declare/assign values to variables.
In FMS, the instance of data being used as a variable name happens often. This PR suggests changes to these variable names, and does not include any directories/modules that are either no longer used and/or deprecated (i.e. axis_utils, mpp_io, fms_io, etc).

Fixes # 1328

How Has This Been Tested?
autotools with gcc/13.1.0, netcdf/4.9.2, mpich/4.1.2, hdf5/1.14.1-2, libyaml/0.2.5

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

mcallic2 and others added 30 commits August 9, 2023 15:07
@mcallic2
data to axis_data, may not be needed (old axis_utils)
46a6990
@mcallic2
data to return_data in data_override_3d routine in data_override.F90
7d4632e
@mcallic2
data to return_data in data_override_UG_1d routine
5e41144
@mcallic2
data to return_data in data_override_UG_2d routine
46655fe
@mcallic2
data to field_data in sum_field_2d routine
16ceba6
@mcallic2
data to field_data in sum_field_3d routine
d768dfc
@mcallic2
data to field_data in sum_field_wght_3d routine
5f0591d
@mcallic2
data to field_data in sum_field_2d_hemi routine
5ec8d44
@mcallic2
data to field_data in ensemble_file_name routine
7883dca
@mcallic2
data to array_data and data type to diag_type_data in diag_axis_init …
7b029e9 
…routine
@mcallic2
data to array_data and data type to diag_type_data in get_diag_axis r…
3cecfda 
…outine
@mcallic2
data to axis_data and data type to diag_data_type in get_diag_axis_da…
e4549ad 
…ta routine
@mcallic2
change data pointer to diag_type_data
d4e7364
@mcallic2
Revert "change data pointer to diag_type_data"
655676b 
This reverts commit d4e7364.
@mcallic2
change data pointer to diag_type_data
4fde62c
@mcallic2
data to center_data in init_diurnal_axis routine
582f4a9
@mcallic2
data to open_file_data in opening_file routine
ce1adfa
@mcallic2
data to com_data
c00c42a
@mcallic2
data to set_field_data
25ec00c
@mcallic2
data to get_are_data in get_area_elements_fms2_io routine
f1c79f5
@mcallic2
data to stock_data in all stock_move_* routines
ed5030c
@mcallic2
changes loval stock_data name to be more descriptive to routine
02eb9ff
@mcallic2
changes data to grid_data in routine data_sum
305a4d2
@mcallic2
change data to latlon_data in routine get_axis_latlon_data
13c7e47
@mcallic2
change data to level_data in routine get_axis_level_data
e367dce
@mcallic2
change data' to data_array5d` to interpolator_type
226dc21
@mcallic2
changes 'data' to 'char_data' in routine mpp_broadcast_char
aced3c2
@mcallic2
changes 'data' to 'char_data' in routine mpp_broadcast_char
57823f8
@mcallic2
changes 'data' to 'index_data' in routine find_index
dbc2251
@mcallic2
Merge branch 'NOAA-GFDL:main' into keywords
adf85df
@mcallic2
change domain_axis_spec type 'data' to 'domain_data'
ca69afb
@mcallic2
changes 'data' to 'char_data' in routine mpp_broadcast_char
b55688d 
This reverts commit aced3c2.
@mcallic2
'data' to 'char_data' in routine mpp_broadcast_char
e71b6ea
@mcallic2
'data' to 'char_data' routine mpp_broadcast_char
e156515
@mcallic2
'data' to 'index_data' in function find_index
a6ec16c
@mcallic2
'data' to 'gather_data' in routines mpp_gather_pelist_*
48dc463
@mcallic2
array3D type 'data' to 'data3D_type' in mpp_gather_pelist_3d
9f7cf07
@mcallic2
'data' to 'input_data' in routine mpp_scatter_pelist_*
c6c7805
@mcallic2
array3d type 'data' tp 'data3D_type'
4e44eae
@mcallic2
'data' to 'broadcast_data' in routine mpp_broadcast
a0d318c
@mcallic2
'data' to 'broadcast_data' in routine mpp_broadcast_*
60cfaec
@mcallic2
merge main
7798bc9
@mcallic2
change all variables named 'data' in test_mpp_*
07b08fb
@mcallic2
whitespace and line lengths
5182daa
@mcallic2
Revert "data to axis_data, may not be needed (old axis_utils)"
95cb4a4 
This reverts commit 46a6990.
@mcallic2 mcallic2 marked this pull request as ready for review August 23, 2023 17:56
@mcallic2
Copy link
Contributor Author

change branch name

@mcallic2 mcallic2 closed this Aug 25, 2023
@mcallic2 mcallic2 deleted the keywords branch August 25, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-robinson thomas-robinson Awaiting requested review from thomas-robinson

@bensonr bensonr Awaiting requested review from bensonr bensonr is a code owner

@rem1776 rem1776 Awaiting requested review from rem1776 rem1776 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mcallic2