Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix yaml parser trim filename bug with gcc #1349

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

rem1776
Copy link
Contributor

@rem1776 rem1776 commented Aug 22, 2023

Description
fixes the parser output test failing from bad file names outputted with gcc + prod flags. Just needed to replace the function isspace with a char comparison and the trim works properly.

How Has This Been Tested?
make check on amd box with gcc 13 + prod flags

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@rem1776 rem1776 merged commit 3ffc427 into NOAA-GFDL:main Aug 23, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants