Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement time_none #1347

Merged
merged 35 commits into from
Aug 24, 2023
Merged

Implement time_none #1347

merged 35 commits into from
Aug 24, 2023

Conversation

uramirez8707
Copy link
Contributor

@uramirez8707 uramirez8707 commented Aug 21, 2023 •
edited
Loading

Description

  1. Implements the "time_none" reduction method
  2. Update the test_time_none.sh to test with the new diag manager
  3. Fixes a bug related to the subaxis
  4. Added the compute indices for the subaxis (this is needed when doing the math)
  5. Replace the pointer remapping with a regular copy because we can't guarantee that the data send in is contiguous and that will cause undefined behavior

There seems to be an issue with the checks in CI. I have not been able to reproduce the error outside of the CI. The checks are currently commented out.

Fixes # (issue)

How Has This Been Tested?
CI, including new tests!

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@uramirez8707
Add tests and checks
0717225
@uramirez8707
minor update
394b9b4
@uramirez8707
fixes for halo tests
026c0f9
@uramirez8707
rename test script to test_time_none
608744f
@uramirez8707
add min tests
65f6541
@uramirez8707
add tests for time_max
80b3897
@uramirez8707
forgot to git add the new files
da6c92b
@uramirez8707
Attempt to add a time_sum test. Needs some work as some tests are fai…
2a5067b 
…ling
@uramirez8707
Merge branch 'dmUpdate' of github.com:NOAA-GFDL/FMS into time_none_tests
90ebe46
@uramirez8707
Revert "Attempt to add a time_sum test. Needs some work as some tests…
0b9113a 
… are failing"

This reverts commit 2a5067b.
@uramirez8707
rever change to test_diag_update_buffer
1f9cc02
@uramirez8707
remove test_dm_openmp as it is not necessary anymore
ad47337
@uramirez8707
minor documentation updates
675f37a
@uramirez8707
add missing script to DIST
c3bc53a
@uramirez8707
pushing for the day, tries to implement time_none
d2a9811
@uramirez8707
implement time_none
00cded4
@uramirez8707
Merge branch 'dmUpdate' of github.com:NOAA-GFDL/FMS into time_none_4_…
6baf85e 
…real
@uramirez8707
push so i can debug on gaea
3d1acc3
@uramirez8707
finish implement time_none, needs MAJOR clean up
9e4ac3c
@uramirez8707
some clean up and documentation
560bbfe
@uramirez8707
more documentation updates to the diag_object and diag_bbox
1982935
@uramirez8707
more documentation updates, fix lint
ec707f2
@uramirez8707
move a use statement so that it can compile without yaml
686b2b7
@uramirez8707
lint fix
086931e
@uramirez8707
Fix some bugs in %rebase_input and don't use pointer remapping
31c0e8c
@uramirez8707
improve error messages in check_time_none, run all of the tests
2ecb2aa
@uramirez8707
turn off checks
cfd5fd3
@uramirez8707
refactor fms_diag_do_reduction
a46f325
@uramirez8707
move a line
6d6529d
@uramirez8707
renames a variable
fd034db
@thomas-robinson
Copy link
Member

  1. What is the issue with the CI?
  2. Why can't we guarantee that the incoming data is contiguous? I'd really like to avoid using copies as much as possible.

thomas-robinson
thomas-robinson requested changes Aug 22, 2023
View reviewed changes
diag_manager/fms_diag_bbox.F90 Outdated Show resolved Hide resolved
diag_manager/fms_diag_bbox.F90 Outdated Show resolved Hide resolved
diag_manager/fms_diag_bbox.F90 Outdated Show resolved Hide resolved
diag_manager/fms_diag_bbox.F90 Outdated Show resolved Hide resolved
diag_manager/fms_diag_object.F90 Show resolved Hide resolved
diag_manager/fms_diag_object.F90 Show resolved Hide resolved
diag_manager/include/fms_diag_reduction_methods_r4.fh Show resolved Hide resolved
@uramirez8707
Copy link
Contributor Author

The "CI issue" is fixed in e0cc678. The CI was failing with --enable-mixed-mode, it was not getting the subregion indices correctly. I turned the checks back on.

@thomas-robinson thomas-robinson merged commit 07ff067 into NOAA-GFDL:dmUpdate Aug 24, 2023
18 checks passed
@uramirez8707 uramirez8707 deleted the time_none_4_real branch August 24, 2023 18:37
@uramirez8707 uramirez8707 restored the time_none_4_real branch August 24, 2023 18:39
@uramirez8707 uramirez8707 deleted the time_none_4_real branch August 24, 2023 18:43
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
@uramirez8707
feat: modern diag implement time_none reduction (NOAA-GFDL#1347)
758929c
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
@uramirez8707
feat: modern diag implement time_none reduction (NOAA-GFDL#1347)
7f3b534
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
@uramirez8707
feat: modern diag implement time_none reduction (NOAA-GFDL#1347)
6425342
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
@uramirez8707
feat: modern diag implement time_none reduction (NOAA-GFDL#1347)
f8f4c1c
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
@uramirez8707
feat: modern diag implement time_none reduction (NOAA-GFDL#1347)
916ac98
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
@uramirez8707
feat: modern diag implement time_none reduction (NOAA-GFDL#1347)
5c2b0c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rem1776 rem1776 rem1776 approved these changes

@thomas-robinson thomas-robinson thomas-robinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uramirez8707 @thomas-robinson @rem1776