mixed precision Update mixedmode_base #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 18, 2023 10:21
mlee03
requested review from
thomas-robinson,
bensonr and
rem1776
as code owners
mlee03
commented
Aug 18, 2023
| @@ -419,6 +419,13 @@ end subroutine init_nonblock_type | |||
| field2(isd:ied, jsd:jed) = field_in(:,:) | |||
| endif | |||
|
|
|||
| ! allocate field1 on pelist1 | |||
There was a problem hiding this comment.
@laurenchilutti, I just wanted to make sure that the changes in mpp are correct here.
There was a problem hiding this comment.
Yep, this looks correct.
mlee03
commented
Aug 18, 2023
| @@ -144,22 +144,22 @@ subroutine compressed_write_1d(fileobj, variable_name, cdata, unlim_dim_level, & | |||
| type is (integer(kind=i4_kind)) | |||
| call mpp_gather(cdata, size(cdata), buf_i4_kind, fileobj%compressed_dims(compressed_dim_index(2))%npes_nelems, & | |||
| fileobj%pelist) | |||
| call netcdf_write_data(fileobj, variable_name, buf_i4_kind, & | |||
| if (fileobj%is_root) call netcdf_write_data(fileobj, variable_name, buf_i4_kind, & | |||
There was a problem hiding this comment.
@uramirez, do these changes look correct? (and also for the ones in test_fms)
There was a problem hiding this comment.
I think this is @laurenchilutti's update actually, it looks right to me.
mcallic2
approved these changes
Aug 21, 2023
rem1776
approved these changes
Aug 23, 2023
| @@ -144,22 +144,22 @@ subroutine compressed_write_1d(fileobj, variable_name, cdata, unlim_dim_level, & | |||
| type is (integer(kind=i4_kind)) | |||
| call mpp_gather(cdata, size(cdata), buf_i4_kind, fileobj%compressed_dims(compressed_dim_index(2))%npes_nelems, & | |||
| fileobj%pelist) | |||
| call netcdf_write_data(fileobj, variable_name, buf_i4_kind, & | |||
| if (fileobj%is_root) call netcdf_write_data(fileobj, variable_name, buf_i4_kind, & | |||
There was a problem hiding this comment.
I think this is @laurenchilutti's update actually, it looks right to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings in changes from main to mixedmode_base