Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mixed precision exchange #1341

Merged
merged 56 commits into from
Aug 30, 2023
Merged

mixed precision exchange #1341

merged 56 commits into from
Aug 30, 2023

Conversation

mcallic2
Copy link
Contributor

@mcallic2 mcallic2 commented Aug 17, 2023 •
edited
Loading

Description
This pr includes changes to add mixed precision capabilities, all real values and math will stay in 64bit precision
This also changes variable declarations to be more aligned

Fixes # (issue)

How Has This Been Tested?
autotools with gcc/13.1.0, netcdf/4.9.2, mpich/4.1.2, hdf5/1.14.1-2, libyaml/0.2.5
and with oneapi/2023.2, compiler-rt/2023.2.1, compiler/2023.2.1, hdf5/1.14.1-2, libyaml/0.2.5,
tbb/2021.10.0, oclfpga/2023.2.1, mpi/2021.10.0, netcdf/4.9.2

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

J-Lentz and others added 30 commits February 1, 2023 08:28
@J-Lentz
fix: misspellings and rename variable in yaml_parser.F90 (NOAA-GFDL#1127
485d631 
)
@mlee03
fix: module and local variable name conflicts in time_interp (NOAA-GF…
35a5f2a 
…DL#1125)

Co-authored-by: mlee03 <[email protected]>
@J-Lentz
docs: Correct instructions to build without MPI (NOAA-GFDL#1128)
ba9c712
@ganganoaa
fix: pointer to allocatable in amip_interp_type (NOAA-GFDL#1106)
15df841
@rem1776
feat: log_diag_field_info updates from diag rewrite (NOAA-GFDL#1117)
f0e8cab
@uramirez8707
fix: remove implied save for valid_types variables in sat_vapor_pres_k (
ec2020a 
NOAA-GFDL#1120)
@rem1776
revert: log_diag_field_info argument changes (NOAA-GFDL#1136)
4526cc9 
Co-authored-by: rem1776 <[email protected]>
@ngs333
feat: refactored send_data math (field buffer update) functions. (NOA…
6255971 
…A-GFDL#1131)
@ngs333
fix: adds tags to nested do loops in fms_diag_fieldbuff.fh to fix his…
74d8e73 
…tory file issues (NOAA-GFDL#1139)
@nikizadehgfdl
fix - gnu and pgi issue with class(*) in send_data3d (NOAA-GFDL#1149)
9b83c8c
@J-Lentz
feat: extend string interface in fms_string_utils_mod (NOAA-GFDL#…
9339b88 
…1142)
@ganganoaa
fix: add omp directives for race condition in tridiagonal (NOAA-GFDL#…
0ff254e 
…1109)
@nikizadehgfdl
fix: missing if statement in PR NOAA-GFDL#1149 (NOAA-GFDL#1155)
6362657
@mlee03
fix: time_manager missing changes from year to yr, month to mo, day t…
7188e3a 
…o dy (NOAA-GFDL#1169)
@rem1776
chore: update changelog and version numbers for release (NOAA-GFDL#1167)
8a78fac
@github-actions
chore: append dev to version number post-release (NOAA-GFDL#1179)
003b8e1
@rem1776 @uramirez8707
feat: merge 2023.01.01 changes into main (NOAA-GFDL#1259)
011b510 
* fix: fms2 io performance update for domain_reads (NOAA-GFDL#1226)

* fix: fms2 io performance update for compressed writes (NOAA-GFDL#1227)

* chore: build/log updates for patch (NOAA-GFDL#1247)

Co-authored-by: uramirez8707 <[email protected]>
Co-authored-by: rem1776 <[email protected]>
@rem1776 @mcallic2
@J-Lentz @mlee03
feat: mixed precision for axis_utils2, horiz_interp, sat_vapor_pressu…
23b86db 
…re, and fms_mod (NOAA-GFDL#1239) (NOAA-GFDL#1258)

* feat: mixed precision axis_utils2 (NOAA-GFDL#1104)

* feat: mixed precision fms_mod (NOAA-GFDL#1147)

* feat: horiz interp mixed precision (NOAA-GFDL#1067)

* mixed precision sat_vapor_pressure  (NOAA-GFDL#1095)

* feat: add mixed precision axis_utils unit tests (NOAA-GFDL#1172)

* fix: move type definitions to before first usage to fix nvhpc bug (NOAA-GFDL#1187)

* fix: change allocatable type for intel errors (NOAA-GFDL#1221)

Co-authored-by: Caitlyn McAllister <[email protected]>
Co-authored-by: Jesse Lentz <[email protected]>
Co-authored-by: MiKyung Lee <[email protected]>
@dkokron
fix: replace current_peset_num with 'n' which should be the active pe…
af15993 
…list. (NOAA-GFDL#1246)
@laurenchilutti
fix: gcc class(*) bug workaround for character arrays (NOAA-GFDL#1163)
de03798
@uramirez8707
fix: improve error messages in fms2_io (NOAA-GFDL#1183)
16d71a2
@uramirez8707
feat: fms2_io unpack data (NOAA-GFDL#1231)
22c498e
@J-Lentz
fix: improve doxygen comment for tranlon (NOAA-GFDL#1257)
cf5035f
@rem1776
fix: ifort 2022.3.0 & greater ICE bug in alltoall test + missing inpu…
ecc1361 
…t nmls in mpp scripts (NOAA-GFDL#1158)
@ganganoaa
fix: checks placed before allocating pointers passed into routines (N…
783019f 
…OAA-GFDL#1152)
@J-Lentz
fix: continuation line syntax for fms2_io error messages (NOAA-GFDL#1265
5e130ef 
)
@rem1776
fix: update doc site deployment action(NOAA-GFDL#1078)
84b330a
@rem1776
fix: warnings in test_mpp_nesting.F90 (NOAA-GFDL#1118)
ef8b5e3
@mcallic2
chore!: deprecate fms/mpp_io with use_deprecated_io macro (NOAA-GFDL#…
3138e4a 
…1064)

BREAKING CHANGE: This commit removes mpp_io_mod and fms_io_mod, along with other routines that use the modules, from default compilation. The -Duse_deprecated_io CPP flag or --enable-deprecated-io configure time flag can be used to enable their compilation.
@J-Lentz
fix: field exists check for io update (NOAA-GFDL#1193)
cbceb9f
rem1776 and others added 13 commits July 13, 2023 14:57
@rem1776
chore: add prefixed aliases for libfms routines (NOAA-GFDL#1262)
2be8aa4 
BREAKING CHANGE: Any code using the global fms module (libFMS.F90) will break as this adds prefixes to all names in that module.
@J-Lentz
fix: add fms_stacksize.c to fms_c_src_files in CMakeLists.txt (NOAA-G…
0e4a675 
…FDL#1285)
@rem1776
chore: update changelog for 2023.02 release (NOAA-GFDL#1306)
c7a70e7
@github-actions
chore: append dev to version number post-release (NOAA-GFDL#1308)
c982456
@rem1776
CI: update gnu image and add dockerfile (NOAA-GFDL#1206)
0efc2e5
@laurenchilutti
fix: test_read_input_nml2 failure and test_diag_update_buffer.F90 seg…
6b699a1 
… fault with Cray (NOAA-GFDL#1302)
@laurenchilutti
fix: initialize nest_level pointer in the nest_domain_type declaratio…
db92c30 
…n to null (NOAA-GFDL#1294)
@J-Lentz
fix: sat_vapor_pres test failure with Cray (NOAA-GFDL#1299)
a0e2128
@rem1776
fix: initialize logicals in horiz_interp_type declaration (NOAA-GFDL#…
a13de5b 
…1283)
@laurenchilutti
fix: mpp_check_field fix for test_mpp_domains2 (NOAA-GFDL#1292)
01d73fb
@laurenchilutti
fix: unallocated variable access in test_mpp_nesting (NOAA-GFDL#1336)
5326fd9
@mcallic2
merge mixedmode
0bd9c38
@mcallic2
changes for mixed mode
0c0a71e
@mlee03
Copy link
Contributor

mlee03 commented Aug 25, 2023

@mcallic2 could you merge in mixedmode?

@mcallic2
Copy link
Contributor Author

@mlee03 I merged in mixedmode, fingers crossed I did it correctly lol

mlee03
mlee03 reviewed Aug 28, 2023
View reviewed changes
.github/workflows/build_ubuntu_gnu.yml Outdated
@@ -1,37 +0,0 @@
name: Build libFMS test with autotools
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcallic2 could you merge in mixedmode one last time?

@mcallic2
Copy link
Contributor Author

@mlee03 mixedmode merged again, its a miracle!

@rem1776 rem1776 merged commit 0d0f604 into NOAA-GFDL:mixedmode Aug 30, 2023
19 checks passed
rem1776 added a commit that referenced this pull request Sep 20, 2023
@rem1776 @mlee03
@mcallic2 @J-Lentz
feat: expand mixed precision support to most modules (#1366)
b25a7c5 
BREAKING CHANGE: In coupler_types.F90,  `coupler_nd_field_type` and `coupler_nd_values_type` have been renamed to indicate real kind value: `coupler_nd_real4/8_field_type` and `coupler_nd_real4/8_values_type`. The `bc` field within `coupler_nd_bc_type` was modified to use r8_kind within the value and field types, and an additional field added `bc_r4` to use r4_kind values.

Includes:

* feat: eliminate use of real numbers for mixed precision in `block_control` (#1195)

* feat: mixed precision field_manager  (#1205)

* feat: mixed precision random_numbers_mod (#1191)

* feat: mixed precision time_manager reals to r8 and clean up (#1196)

* feat: mixed Precision tracer_manager  (#1212)

* Mixed precision monin_obukhov (#1116)

* Mixed precision: `monin_obukhov` unit tests (#1272)

* mixed-precision diag_integral_mod  (#1217)

* mixed precision time_interp (#1252)

* mixed precision interpolator_mod  (#1305)

* Mixed precision astronomy (#1092)

* Mixed precision `data_override_mod` (#1323)

* mixed precision exchange (#1341)

* coupler mixed precision (#1353)

* Mixed precision topography_mod (#1250)

---------

Co-authored-by: rem1776 <[email protected]>
Co-authored-by: MiKyung Lee <[email protected]>
Co-authored-by: mlee03 <[email protected]>
Co-authored-by: Caitlyn McAllister <[email protected]>
Co-authored-by: Jesse Lentz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlee03 mlee03 mlee03 approved these changes

@J-Lentz J-Lentz J-Lentz approved these changes

@rem1776 rem1776 rem1776 approved these changes

@thomas-robinson thomas-robinson Awaiting requested review from thomas-robinson

@bensonr bensonr Awaiting requested review from bensonr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.