Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add target flags for GNU CI #1339

Closed
wants to merge 8 commits into from

Conversation

rem1776
Copy link
Contributor

@rem1776 rem1776 commented Aug 16, 2023

Description
adds the gnu mkmf template flags for prod and debug to the ci matrix

How Has This Been Tested?
CI, should be working properly. draft until all the tests are passing, needs one or two other fixes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@thomas-robinson
Copy link
Member

Are we using these flags with intel? PROD, REPRO, DEBUG?

@rem1776
Copy link
Contributor Author

rem1776 commented Aug 18, 2023

Are we using these flags with intel? PROD, REPRO, DEBUG?

No this is just for GNU: https://github.com/NOAA-GFDL/mkmf/blob/61495ce9d197a2a54bbcbb5d879fefabb3cf3c01/templates/ncrc5-gcc.mk#L87-L107
Figured I'd make a separate pr for intel.

@rem1776
Copy link
Contributor Author

rem1776 commented Aug 28, 2023

will combine this and #1346 with some more CI updates

@rem1776 rem1776 closed this Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants