fix rec_nll evaluate bug

[Andrea-Havron-NOAA]

What is the feature?

• Fixes bug related to the recruitment nll evaluation
• The value from the bool, estimate_log_devs was not being passed from the interface into the model
• The model bool was true by default so the recruitment nll was being evaluated regardless if the recruitment deviations were being estimated.

How have you implemented the solution?

Passed the bool value from the interface to the model

Does the PR impact any other area of the project?

This fix will change the overall joint negative log-likelihood and the recruitment negative log-likelihood reported from the model

How to test this change

fims_demo.Rmd should print a value of 0 from the recruitment nll, report$rec_nll

Developer pre-PR checklist

• I relied on GitHub actions to 🧪 things for me while I sat on the 🛋️.

[github-actions]

Instructions for code reviewer

Hello reviewer, thanks for taking the time to review this PR!

• Please use this checklist during your review, checking off items that you have verified are complete!
• For PRs that don't make changes to code (e.g., changes to README.md or Github actions workflows), feel free to skip over items on the checklist that are not relevant. Remember it is still important to do a thorough review.
• Then, comment on the pull request with your review indicating where you have questions or changes need to be made before merging.
• Remember to review every line of code you’ve been asked to review, look at the context, make sure you’re improving code health, and compliment developers on good things that they do.
• PR reviews are a great way to learn, so feel free to share your tips and tricks. However, for optional changes (i.e., not required for merging), please include nit: (for nitpicking) before making the suggestion. For example, nit: I prefer using a data.frame() instead of a matrix because...
• Engage with the developer when they respond to comments and check off additional boxes as they become complete so the PR can be merged in when all the tasks are fulfilled. Make it clear when this has been reached by commenting on the PR with something like This PR is now ready to be merged, no changes needed.

Checklist

• The PR is requested to be merged into the appropriate branch (typically main)
• The code is well-designed.
• The functionality is good for the users of the code.
• Any User Interface changes are sensible and look good.
• The code isn’t more complex than it needs to be.
• Code coverage remains high, indicating the new code is tested.
• The developer used clear names for everything.
• Comments are clear and useful, and mostly explain why instead of what.
• Code is appropriately documented (doxygen and roxygen).

[Andrea-Havron-NOAA]

@Bai-Li-NOAA or @ChristineStawitz-NOAA, can either of you review and approve this PR?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.56%. Comparing base (93c2625) to head (6a68fd1).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #615      +/-   ##
==========================================
+ Coverage   78.54%   78.56%   +0.01%     
==========================================
  Files          36       36              
  Lines        1944     1945       +1     
  Branches      141      141              
==========================================
+ Hits         1527     1528       +1     
  Misses        374      374              
  Partials       43       43              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.