Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commenting out more inconsistent tests #241

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Commenting out more inconsistent tests #241

merged 3 commits into from
Sep 9, 2024

Conversation

AlysonStahl-NOAA
Copy link
Collaborator

Part of #175

edwardhartnett
edwardhartnett reviewed Aug 26, 2024
View reviewed changes
Copy link
Contributor

@edwardhartnett edwardhartnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this all the ip tests?

@AlysonStahl-NOAA
Copy link
Collaborator Author

In this case, yes.

@AlysonStahl-NOAA AlysonStahl-NOAA marked this pull request as ready for review August 26, 2024 16:10
@AlysonStahl-NOAA
Copy link
Collaborator Author

Re-requesting a review since it's not letting me merge this for some reason.

edwardhartnett
edwardhartnett approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@edwardhartnett edwardhartnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve but I don't like it. We need a better solution than just turn off all tests!

@AlysonStahl-NOAA AlysonStahl-NOAA merged commit 0b980be into NOAA-EMC:develop Sep 9, 2024
9 checks passed
@AlysonStahl-NOAA AlysonStahl-NOAA deleted the as_tests8 branch September 9, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardhartnett edwardhartnett edwardhartnett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlysonStahl-NOAA @edwardhartnett