Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marine ens. var. #37

Merged
merged 9 commits into from
Oct 30, 2024
Merged

Marine ens. var. #37

merged 9 commits into from
Oct 30, 2024

Conversation

guillaumevernieres
Copy link
Contributor

Companion PR to NOAA-EMC/GDASApp#1353

@danholdaway
Copy link
Collaborator

To get the tests passing you have to add a dummy template for marine_vt_levels here: https://github.com/NOAA-EMC/jcb/blob/develop/test/client_integration/gdas-marine-templates.yaml

@danholdaway
Copy link
Collaborator

Though this makes me realize that life would be easier if those test YAMLs were housed with the jcb-gdas. I'll do that quickly first and you can save having the joint PRs.

@AndrewEichmann-NOAA
Copy link

Does the argo yaml have any relationship to the yamls in parm/soca/obs/config?

Copy link

@AndrewEichmann-NOAA AndrewEichmann-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing obviously wrong to me

@guillaumevernieres
Copy link
Contributor Author

Does the argo yaml have any relationship to the yamls in parm/soca/obs/config?

Yes. @JohnSteffen-NOAA is working on updating them in this repository.

@danholdaway danholdaway merged commit 1e9d844 into develop Oct 30, 2024
1 check passed
@danholdaway danholdaway deleted the feature/marineenvar branch October 30, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants