Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obselete entries and add "reduce obs space" option iasi filter #29

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

emilyhcliu
Copy link
Contributor

@emilyhcliu emilyhcliu commented Sep 24, 2024

This PR proposes the following changes for IASI:

  1. Remove obsolete entries related to QC flags in the observation filter
  2. Rename mtiasi to iasi
  3. Add `reduce obs space

There is a companion GDASApp PR #1292
This partly resolves Issue NOAA-EMC/GDASApp#1291

@emilyhcliu
Copy link
Contributor Author

@danholdaway Thanks for reviewing this PR.

@emilyhcliu
Copy link
Contributor Author

Test failed with the following message:platform linux -- Python 3.12.6, pytest-8.3.3, pluggy-1.5.0 -- /opt/hostedtoolcache/Python/3.12.6/x64/bin/python
cachedir: .pytest_cache
rootdir: /home/runner/work/jcb-gdas/jcb-gdas/jcb_repo
collecting ... collected 5 items

Error: The operation was canceled.

This does not look like a working test.
Can we merge this PR?

@danholdaway danholdaway merged commit 4bce236 into develop Oct 23, 2024
1 check passed
@danholdaway danholdaway deleted the feature/iasi branch October 23, 2024 16:04
CoryMartin-NOAA added a commit to NOAA-EMC/GDASApp that referenced this pull request Nov 6, 2024
1. Rename mtiasi to iasi in GDASApp
2. There is a companion [PR
#29](NOAA-EMC/jcb-gdas#29) in jcb-gdas
- rename mtiasi to iasi
- add `reduce obs space`
- remove obsolete QC-flag related variables in filters

This partly resolves Issue #1291

Co-authored-by: Emily Liu <[email protected]>
Co-authored-by: Cory Martin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants