Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revive the marine jcb implementation #26

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Conversation

guillaumevernieres
Copy link
Contributor

Some updates/fixes to the marine yaml templates.

@guillaumevernieres
Copy link
Contributor Author

As I'm adjusting the cases, I'm realizing that I'm not making use of the soca_2cice yaml ... Is that the proper location for these yamls?

  • soca_2cice: it's coded as a change of variables and inserts the ice analysis in the cice restart
  • the soca2mom6 yaml is for the app that prepares the mom6 iau increment

Copy link

@AndrewEichmann-NOAA AndrewEichmann-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me

@CoryMartin-NOAA
Copy link
Contributor

@danholdaway just an FYI I think the JCB-GDAS CI tests always fail, not sure why (haven't looked into it)

@CoryMartin-NOAA CoryMartin-NOAA merged commit 25c66b8 into develop Sep 17, 2024
1 check failed
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/marinevar branch September 17, 2024 12:51
guillaumevernieres referenced this pull request in NOAA-EMC/GDASApp Sep 18, 2024
This PR needs to be merged before
-
[https://github.com/NOAA-EMC/global-workflow/pull/2920](https://github.com/NOAA-EMC/global-workflow/pull/2920)
 
It depends on 
-
[https://github.com/NOAA-EMC/jcb-gdas/pull/26](https://github.com/NOAA-EMC/jcb-gdas/pull/26)

and will require an update to the `jcb-gdas` submodules.

It will break the GDASApp marine CI until the `g-w` pr is merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants