Update JGDAS ENKF ECEN job

[mingshichen-noaa]

Description

NCO has requested that each COM variable specify whether it is an input or an output. This completes that process for the global jgdas enkf ecen job.

Refs #2451

Type of change

• Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

• Is this a breaking change (a change in existing functionality)? NO
• Does this change require a documentation update? NO

How has this been tested?

• Clone and build on RDHPCS
• Cycled tests on Hercules
• Forecast-only tests on Hercules

Checklist

• Any dependent changes have been merged and published
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• New and existing tests pass with my changes
• I have made corresponding changes to the documentation if necessary

[CoryMartin-NOAA]

Why are there no changes for COM_ATMOS_ANALYSIS_STAT?

[KateFriedman-NOAA]

I second @CoryMartin-NOAA 's comment. Changes in this PR look good so far but there are other COM variables in scripts/exgdas_enkf_ecen.sh that also need to be updated to their COMIN/COMOUT versions. Please update those variables as well, thanks!

[mingshichen-noaa]

@CoryMartin-NOAA @KateFriedman-NOAA
Hi both,
I am sorry to have missed git push. Right now I have made updating.

[KateFriedman-NOAA]

I am sorry to have missed git push. Right now I have made updating.

@mingshichen-noaa Thanks for committing those additional updates. Question, the testing you did included these COM changes that you just pushed?

[mingshichen-noaa]

Kate,
Yes, testing and git push were done yesterday.

[CoryMartin-NOAA]

I agree with @KateFriedman-NOAA those are links to files produced by executables and thus should be COMOUT

[mingshichen-noaa]

Kate,
I agree with your comments and suggestions. I have made change and done git add/commit/push them.

[KateFriedman-NOAA]

I think the changes are correct now. Approve pending successful completion of CI tests and approval by other reviewers.

[emcbot]

CI Passed on Hercules in Build# 1
Built and ran in directory /work2/noaa/global/CI/HERCULES/3050

Experiment C48_ATM_62510c21 Completed 2 Cycles: *SUCCESS* at Tue Nov  5 10:47:48 CST 2024
Experiment C96_S2SWA_gefs_replay_ics_62510c21 Completed 1 Cycles: *SUCCESS* at Tue Nov  5 10:53:56 CST 2024
Experiment C48_S2SW_62510c21 Completed 2 Cycles: *SUCCESS* at Tue Nov  5 11:48:40 CST 2024
Experiment C96C48_hybatmDA_62510c21 Completed 3 Cycles: *SUCCESS* at Tue Nov  5 12:37:35 CST 2024
Experiment C96_atm3DVar_62510c21 Completed 3 Cycles: *SUCCESS* at Tue Nov  5 12:43:36 CST 2024
Experiment C48_S2SWA_gefs_62510c21 Completed 1 Cycles: *SUCCESS* at Tue Nov  5 13:02:17 CST 2024