Refactor gridded wave post #3014
Conversation
AntonMFernando-NOAA
requested review from
JessicaMeixner-NOAA,
sbanihash and
WalterKolczynski-NOAA
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| fi | ||
| fhrg=$fhr | ||
| sleep_interval=10 | ||
| iwaitmax=120 # Maximum loop cycles for waiting until wave component output file is ready (fails after max) | ||
| while [ $fhr -le $FHMAX_WAV ]; do | ||
|
|
||
| if [ $fhr -le $FHMAX_WAV ]; then |
There was a problem hiding this comment.
I would just take this out. It is up to the workflow to determine which hours to run for.
There was a problem hiding this comment.
@WalterKolczynski-NOAA All contents inside the loop? L239 - L432 or just the loop?
There was a problem hiding this comment.
Just the if that replaces the while Still need most of the stuff inside it.
There was a problem hiding this comment.
Didn't delete it. Just commented it out.
| if [ "${RERUN:-NO}" = "YES" ]; then | ||
| fhr=$((FHRUN + FHMIN_WAV)) | ||
| if [ $FHMAX_HF_WAV -gt 0 ] && [ $FHOUT_HF_WAV -gt 0 ] && [ $fhr -lt $FHMAX_HF_WAV ]; then | ||
| FHINCG=$FHOUT_HF_WAV | ||
| else | ||
| FHINCG=$FHOUT_WAV | ||
| fi | ||
| fhr=$((fhr + FHINCG)) | ||
| fhr=$((FORECAST_HOUR + FHINCG)) | ||
| else | ||
| fhr=$FHMIN_WAV | ||
| fhr=$FORECAST_HOUR |
There was a problem hiding this comment.
This section can just be removed. The forecast hour is provided and does not need to be calculated anymore.
| if [ $FHMAX_HF_WAV -gt 0 ] && [ $FHOUT_HF_WAV -gt 0 ] && [ "$fhr" -lt $FHMAX_HF_WAV ]; then | ||
| FHINCG=$FHOUT_HF_WAV | ||
| else | ||
| FHINCG=$FHOUT_WAV | ||
| fi | ||
| fhrg=$((fhr+FHINCG)) | ||
| fi | ||
| echo $fhrg | ||
| echo "$fhrg" | ||
|
|
||
| fhr=$fhrg #loop with out_grd stride |
There was a problem hiding this comment.
This is more stuff to calculate the next hour to run when it was a loop and is no longer needed.
There was a problem hiding this comment.
@WalterKolczynski-NOAA Modified gfs_tasks.py and did your suggested changes to exgfs_wave_post_gridded_sbs.sh. Ran GEFS and GFS tests on HERCULES and they all passed. Did a check on output files and see no difference (between develop and current branches). Anymore suggestions?
…nando-NOAA/global-workflow into feature/wave_post_grid
…nando-NOAA/global-workflow into feature/wave_post_grid
…nando-NOAA/global-workflow into feature/wave_post_grid
…nando-NOAA/global-workflow into feature/wave_post_grid
Description
The gridded wave post (wavepostsbs) script currently loops over all forecast hours and acts as its own post manager. Other component post and product scripts operate on one forecast time. This PR will update the wave post to match other components, that creates a bunch of short jobs instead of one long job (per member).
Resolves #2290
Type of change
Change characteristics
How has this been tested?
Checklist