-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow APP to differ between RUNs #2943
base: develop
Are you sure you want to change the base?
Allow APP to differ between RUNs #2943
Conversation
This is going to require some more leg work as some APP-specific flags are currently read in without specifying a global-workflow/workflow/applications/applications.py Lines 34 to 50 in c6e3262
This will require reworking the |
217ec77
to
8275caf
Compare
This PR now correctly generates identical CI XMLs as compared to develop (with the exception of the Marking ready for review. |
Hercules was already correct Refs NOAA-EMC#2956
Experiment C48_ATM FAILED on Orion in Build# 1 in |
Experiment C96_S2SWA_gefs_replay_ics FAILED on Orion in Build# 1 in |
CI Failed on Orion in Build# 1
|
4489259
to
76a62d0
Compare
I'm having some issues with this branch after merging the interval PR. Converting to draft until I get it squared away. |
All features are working again. Reopening this PR for review. |
@@ -133,11 +133,8 @@ export DO_COUPLED="NO" | |||
export DO_WAVE="NO" | |||
export DO_OCN="NO" | |||
export DO_ICE="NO" | |||
export DO_AERO="NO" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there no DO_AERO
for GEFS anymore (and not exported for GFS)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because aerosols are controlled at the forecast and analysis level, not the application level.
For instance, previously, this was implemented in the config.fcst
config by reading the AERO_FCST_RUN
variable:
global-workflow/parm/config/gfs/config.fcst
Lines 11 to 21 in 152bb45
# Turn off waves if not used for this RUN | |
case ${WAVE_RUN} in | |
both | "${RUN/enkf}" ) ;; # Don't change | |
*) DO_WAVE="NO" ;; # Turn waves off | |
esac | |
# Turn off aerosols if not used for this RUN | |
case ${AERO_FCST_RUN} in | |
both | "${RUN/enkf}" ) ;; # Don't change | |
*) DO_AERO="NO" ;; # Turn aerosols off | |
esac |
But now, it can rely on just the DO_AERO_FCST
variable.
Keeping the DO_AERO
flag would be redundant since it is superseded by DO_AERO_FCST
(or DO_AERO_ANL
in the analysis jobs).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I debated whether to add DO_AERO
(without exporting) to config.gefs
. When analyses are enabled, having the flag will be handy.
Description
This enables APP to be specified for each RUN. This also removes the need for a
_no_run
configuration dictionary and somewhat simplifies the_init_finalize
method.Resolves #2908
Resolves #2956
Type of change
Change characteristics
How has this been tested?
{"gdas": "S2S", "gfs": "ATM"}
)Checklist