Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UFS-SRW v3.0.0 SciDoc updates #685

Closed
wants to merge 3 commits into from

Conversation

grantfirl
Copy link
Collaborator

Description

This PR updates the scientific documentation in the CCPP physics for UFS-SRW App v3.0.0 release. This should be code comments and text files only and should not have any effect on model results.

Issue(s) addressed

ufs-community/ccpp-physics#96

Testing

See <> for testing information

Dependencies

waiting on ufs-community/ccpp-physics#91

@BrianCurtis-NOAA
Copy link
Collaborator

@zach1221 FYI @ChunxiZhang-NOAA does not work with EMC any more.

@zach1221
Copy link
Collaborator

@zach1221 FYI @ChunxiZhang-NOAA does not work with EMC any more.

@BrianCurtis-NOAA right.. I knew that. I guess I can't reject the request now.

@zach1221
Copy link
Collaborator

@dustinswales @SamuelTrahanNOAA since Grant is out of office, are one of you able to resolve the conflict with this FV3atm PR and update the ccpp-physics submodule pointer and revert the .gitmodules url, following the merge of ccpp-physics PR#91?

@SamuelTrahanNOAA
Copy link
Contributor

Why do you need this PR to be updated? Its changes are obsolete now that the CCPP changes were merged.

@zach1221
Copy link
Collaborator

Why do you need this PR to be updated? Its changes are obsolete now that the CCPP changes were merged.

That makes sense. Thanks @SamuelTrahanNOAA . I'll have it closed after 1844 is merged.

@zach1221
Copy link
Collaborator

Closing this PR, as the changes in ccpp-physics PR #91 have already been merged.

@zach1221 zach1221 closed this Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants