-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the offline domain checks to use a concave hull #215
Update the offline domain checks to use a concave hull #215
Conversation
The update looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Just one minor comment, we can make all .py scripts executable by adding the follwoing shebang:
#!/usr/bin/env python
Thanks @guoqing-noaa! I think that shebang is already added to the top of these python scripts. But I'll update the usage example in the PR text. |
Sorry for the delay. I just did a test, and got 2 problems with my ZTD bufr2ioda file:
The complete test results are in : /scratch1/NCEPDEV/fv3-cam/Hui.Liu/domain_check. Thanks for help checking these in advance. |
@HuiLiu-NOAA thanks for reviewing the PR and catching the longitude issue. I have that line in Speaking of - do you happen to have the ZTD data saved on any other machine? Hera is down today so I cannot investigate #2 right now. |
Thanks @SamuelDegelia-NOAA. We can wait for Hera back. |
@SamuelDegelia-NOAA : |
This PR updates the offline domain checks to use a concave hull approach instead of a convex hull. This hull better matches the shape of the MPAS domain and thus can allow more observations through that are inside the domain. I still recommend using a small value of the hull_shrink_factor (0.5% worked for me) to avoid issues with observations located right on the domain boundary.
This updated version of the domain check takes about 15 seconds longer than the original version.
As mentioned by @delippi, the offline domain checks are meant as temporary solutions until the online domain check is fully functional. We are very close on that, but I want to go ahead and commit this update since it will be useful for validation of that online check.
Usage:
./offline_domain_check_satrad.py -g invariant.nc -o gdas.t00z.atms_all_npp.tm00.nc -s 0.005 -f