Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utility for updating ctest input files during development #202

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

SamuelDegelia-NOAA
Copy link
Contributor

This PR adds a simple shell script based on rrfs-test/CMakeLists.txt that allows developers to update the RRFS ctests in RDASApp. The goal here is to be able to run this quick script if making any changes to the yaml files, test reference files, or input data for the ctests. Previously, the only way to do this was to rebuild all of RDASApp or make temporary changes to build.sh

Please see #184 (comment) for additional motivation.

Note: this script cannot update the ctest configuration (number of tests, test names, or MPI configuration) since those options are handled by ecbuild during the cmake step.

@guoqing-noaa
Copy link
Collaborator

@SamuelDegelia-NOAA Thanks!

This is helpful. Just curious whether it is possible that the CMAKE process also uses the same script to stage data (similar as runnning link_mpasjedi_expr.sh in buid.sh) so that we don't need to maintain two parts?

@SamuelDegelia-NOAA
Copy link
Contributor Author

@guoqing-noaa We could theoretically do that, but we still need the cmake script to create the individual ctests (using ecbuild_add_test). So we would still need to lists the tests inside rrfs-test/CMakeLists.txt even if we went the route you describe. At that point I do not think we would save much by using this new script inside the cmake script.

@guoqing-noaa
Copy link
Collaborator

we still need the cmake script to create the individual ctests (using ecbuild_add_test)
Right. I totally agree with that.

I mean using the same script will avoid making changes in two different locations.
However, I am fine with as is if you wan to maintain two different sets of file copying/linking.

@SamuelDegelia-NOAA
Copy link
Contributor Author

Yeah, I think I would prefer to just keep the two sets. I don't see us needing to change the file copying/linking much. Thanks!

Copy link
Contributor

@hu5970 hu5970 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, merge this one

@hu5970 hu5970 merged commit 06de5e2 into NOAA-EMC:develop Oct 18, 2024
1 check passed
@SamuelDegelia-NOAA SamuelDegelia-NOAA deleted the feature/ctest_copy_script branch October 23, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants