Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update RDASApp submodules to match mpasjedi-v3.0.1 #194

Merged
merged 35 commits into from
Oct 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
035b3c9
update the oops submodule to mpasjedi.v3.0.1
Junjun-NOAA Oct 10, 2024
20698b1
update the ioda submodule to mpasjedi.v3.0.1
Junjun-NOAA Oct 10, 2024
7875315
update the ufo submodule to mpasjedi.v3.0.1
Junjun-NOAA Oct 10, 2024
660aea3
update the vader submodule to mpasjedi.v3.0.1
Junjun-NOAA Oct 10, 2024
95d6514
update the mpas-jedi submodule to mpasjedi.v3.0.1
Junjun-NOAA Oct 10, 2024
61303f9
update the mpas submodule to mpasjedi.v3.0.1
Junjun-NOAA Oct 10, 2024
049f134
use the mpasout files
guoqing-noaa Oct 11, 2024
ce69e31
change git repo for MPAS model
Junjun-NOAA Oct 11, 2024
291e8f4
Merge pull request #1 from guoqing-noaa/patch-jhu-01
Junjun-NOAA Oct 11, 2024
201ffa9
changes related with: invariant.nc, VEGPARM.TBL, mpasout
guoqing-noaa Oct 11, 2024
1b359b6
change restart to mpasout and static.nc to invariant.nc
guoqing-noaa Oct 11, 2024
31adbf8
Merge pull request #2 from guoqing-noaa/patch-jhu-02
Junjun-NOAA Oct 11, 2024
6dad51e
update ioda-data to match mpasjedi.v3.0.1
guoqing-noaa Oct 11, 2024
c7eb001
merge the latest develop branch
guoqing-noaa Oct 12, 2024
03f6dd8
Merge pull request #3 from guoqing-noaa/patch-jhu-03
Junjun-NOAA Oct 12, 2024
449fce0
Merge branch 'develop' into mpasjedi3.0.1
guoqing-noaa Oct 12, 2024
dda4f7d
update fv3-jedi-data to v1.9.0
guoqing-noaa Oct 12, 2024
9c98090
quote iMember for the pattern key
guoqing-noaa Oct 12, 2024
377d973
revert unexpected changes on rrfs-test/testinput/rrfs_mpasjedi_202405…
guoqing-noaa Oct 12, 2024
33a84e1
update the rrfs-test reference files
guoqing-noaa Oct 13, 2024
7a0facf
update testinput_expr/ yaml files to match those under testinput/
guoqing-noaa Oct 13, 2024
fe6906f
update the fv3-jedi submodule to mpasjedi.v3.0.1
Junjun-NOAA Oct 13, 2024
a7c92c3
update the fv3-jedi-lm submodule to mpasjedi.v3.0.1
Junjun-NOAA Oct 13, 2024
0e72f9c
update the fv3-jedi submodule to mpasjedi.v3.0.1
Junjun-NOAA Oct 13, 2024
600ed5d
add crtm/fix_REL-3.1.1.2
guoqing-noaa Oct 13, 2024
3d33515
add a fix/ link under bundle/ as required by CRTMv3 to use local CRTM…
guoqing-noaa Oct 13, 2024
0a5d5ee
commit missed local changes: .gitignore, mpas-jedi-data obs, etc
guoqing-noaa Oct 13, 2024
16cb13a
update fv3-jedi-data to the latest develop branch which fixed a bug a…
guoqing-noaa Oct 13, 2024
eb93baf
revert the submodule changes on fv3-jedi and fv3-jedi-lm
guoqing-noaa Oct 13, 2024
f7f0bee
reading static.nc is changed to invariant.nc in mpasjedi_spread.py
Junjun-NOAA Oct 14, 2024
52c9dc2
revert the RDAS_DATA location change on Hera
guoqing-noaa Oct 15, 2024
ae98bd3
revert the adding of fix_REL-3.1.1.2 CRTM coefficient files
guoqing-noaa Oct 15, 2024
8beb13f
Merge branch 'develop' into mpasjedi3.0.1
guoqing-noaa Oct 15, 2024
c63b604
Merge branch 'develop' into mpasjedi3.0.1
guoqing-noaa Oct 16, 2024
fa3fa34
Merge branch 'develop' into mpasjedi3.0.1
guoqing-noaa Oct 21, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
ignore = all
[submodule "sorc/mpas"]
path = sorc/mpas
url = https://github.com/jcsda-internal/MPAS-Model
url = https://github.com/MPAS-Dev/MPAS-Model
branch = release-stable
ignore = all
[submodule "sorc/mpas-jedi"]
Expand Down
1 change: 1 addition & 0 deletions bundle/mpas-jedi-data/testinput_tier_1/obs
1 change: 0 additions & 1 deletion fix/crtm

This file was deleted.

1 change: 1 addition & 0 deletions fix/crtm/2.3.0
1 change: 1 addition & 0 deletions fix/crtm/2.4.0
1 change: 1 addition & 0 deletions fix/crtm/2.4.1_skylab_4.0
1 change: 1 addition & 0 deletions fix/crtm/fix_REL-3.1.1.2
2 changes: 1 addition & 1 deletion fix/expr_data/mpas_2024052700/bkg
2 changes: 1 addition & 1 deletion fix/expr_data/mpas_2024052700/ens
1 change: 1 addition & 0 deletions fix/expr_data/mpas_2024052700/invariant.nc
2 changes: 1 addition & 1 deletion fix/expr_data/mpas_2024052700/obs
2 changes: 1 addition & 1 deletion fix/jcsda/fv3-jedi-data
2 changes: 1 addition & 1 deletion fix/jcsda/ioda-data
2 changes: 1 addition & 1 deletion fix/physics/VEGPARM.TBL
6 changes: 3 additions & 3 deletions rrfs-test/scripts/link_mpasjedi_expr.sh
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,10 @@ cp ${RDASApp}/rrfs-test/ush/mpasjedi_spread.py .

mkdir -p data
cd data
mkdir -p bumploc bkg obs obs_ctest ens
mkdir -p bumploc obs obs_ctest ens
ln -snf ${RDASApp}/fix/bumploc/${BUMPLOC} bumploc/${BUMPLOC}
ln -snf ${RDASApp}/fix/expr_data/${exprname}/bkg/restart.2024-05-27_00.00.00.nc .
ln -snf ${RDASApp}/fix/expr_data/${exprname}/bkg/restart.2024-05-27_00.00.00.nc static.nc
ln -snf ${RDASApp}/fix/expr_data/${exprname}/bkg/mpasout.2024-05-27_00.00.00.nc .
ln -snf ${RDASApp}/fix/expr_data/${exprname}/invariant.nc invariant.nc
ln -snf ${RDASApp}/fix/expr_data/${exprname}/obs/* obs/
ln -snf ${RDASApp}/fix/expr_data/${exprname}/obs_ctest/* obs_ctest/
ln -snf ${RDASApp}/fix/expr_data/${exprname}/ens/* ens/
Expand Down
4 changes: 2 additions & 2 deletions rrfs-test/scripts/setup_experiment.sh
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,8 @@ elif [[ $DYCORE == "MPAS" ]]; then
mkdir -p data; cd data
mkdir -p bumploc bkg obs ens
ln -snf ${YOUR_PATH_TO_RDASAPP}/fix/bumploc/* bumploc/.
ln -snf ${YOUR_PATH_TO_RDASAPP}/fix/expr_data/${TEST_DATA}/bkg/restart.2024-05-27_00.00.00.nc .
ln -snf ${YOUR_PATH_TO_RDASAPP}/fix/expr_data/${TEST_DATA}/bkg/restart.2024-05-27_00.00.00.nc static.nc
ln -snf ${YOUR_PATH_TO_RDASAPP}/fix/expr_data/${TEST_DATA}/bkg/mpasout.2024-05-27_00.00.00.nc .
ln -snf ${YOUR_PATH_TO_RDASAPP}/fix/expr_data/${TEST_DATA}/invariant.nc invariant.nc
SamuelDegelia-NOAA marked this conversation as resolved.
Show resolved Hide resolved
ln -snf ${YOUR_PATH_TO_RDASAPP}/fix/expr_data/${TEST_DATA}/obs/* obs/
ln -snf ${YOUR_PATH_TO_RDASAPP}/fix/expr_data/${TEST_DATA}/ens/* ens/
cp -p $YOUR_PATH_TO_RDASAPP/rrfs-test/scripts/templates/run_bump_template.sh run_bump.sh
Expand Down
6 changes: 3 additions & 3 deletions rrfs-test/testinput/rrfs_mpasjedi_2024052700_Ens3Dvar.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ cost function:
analysis variables: *incvars
background:
state variables: [spechum,surface_pressure,temperature,uReconstructMeridional,uReconstructZonal,theta,rho,u,qv,pressure,landmask,xice,snowc,skintemp,ivgtyp,isltyp,snowh,vegfra,u10,v10,lai,smois,tslb,pressure_p,qc,qi,qg,qr,qs,cldfrac]
filename: data/restart.2024-05-27_00.00.00.nc
filename: data/mpasout.2024-05-27_00.00.00.nc
guoqing-noaa marked this conversation as resolved.
Show resolved Hide resolved
date: *analysisDate
background error:
covariance model: ensemble
Expand All @@ -66,10 +66,10 @@ cost function:
members from template:
template:
<<: *memberConfig
filename: ./data/ens/mem%iMember%/restart.2024-05-27_00.00.00.nc
filename: ./data/ens/mem%iMember%/mpasout.2024-05-27_00.00.00.nc
pattern: "%iMember%"
start: 1
zero padding: 2
zero padding: 3
nmembers: 30

observations:
Expand Down
2 changes: 1 addition & 1 deletion rrfs-test/testinput/rrfs_mpasjedi_2024052700_bumploc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ geometry:
bump vunit: "modellevel" # modellevel, height
background:
state variables: &vars [spechum,surface_pressure,temperature,uReconstructMeridional,uReconstructZonal]
filename: "./data/restart.2024-05-27_00.00.00.nc"
filename: "./data/mpasout.2024-05-27_00.00.00.nc"
date: *validDate

background error:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ background:
members from template:
template:
<<: *memberConfig
filename: ./data/ens/mem%iMember%/restart.2024-05-27_00.00.00.nc
filename: ./data/ens/mem%iMember%/mpasout.2024-05-27_00.00.00.nc
pattern: "%iMember%"
start: 1
zero padding: 2
zero padding: 3
nmembers: 30

observations:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ background:
members from template:
template:
<<: *memberConfig
filename: ./data/ens/mem%iMember%/restart.2024-05-27_00.00.00.nc
filename: ./data/ens/mem%iMember%/mpasout.2024-05-27_00.00.00.nc
pattern: "%iMember%"
start: 1
zero padding: 2
zero padding: 3
nmembers: 30

observations:
Expand Down
6 changes: 3 additions & 3 deletions rrfs-test/testinput/streams.atmosphere
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
<streams>
<immutable_stream name="static"
<immutable_stream name="invariant"
type="input"
precision="single"
filename_template="data/static.nc"
filename_template="data/invariant.nc"
io_type="pnetcdf,cdf5"
input_interval="initial_only" />

<immutable_stream name="input"
type="input"
precision="single"
filename_template="data/restart.2024-05-27_00.00.00.nc"
filename_template="data/mpasout.2024-05-27_00.00.00.nc"
io_type="pnetcdf,cdf5"
input_interval="initial_only" />

Expand Down
66 changes: 20 additions & 46 deletions rrfs-test/testinput_expr/rrfs_mpasjedi_2024052700_Ens3Dvar.yaml
Original file line number Diff line number Diff line change
@@ -1,41 +1,3 @@

# application-agnostic anchors that specify observation errors
# applicable to Variational, HofX3D

# reusable latitude bands for all observation types
_conventional obs localizations: &heightAndHorizObsLoc
_blank: null

_nonconventional obs localizations: &horizObsLoc
_blank: null

_obs space: &ObsSpace
obs perturbations seed: 1
io pool:
max pool size: 10
distribution:
name: RoundRobin

_obs error diagonal: &ObsErrorDiagonal
covariance model: diagonal
# Note: the same 'obs perturbations seed' must be used for all members for the 'zero-mean perturbations' option to work
zero-mean perturbations: true
member: 1
number of members: 1

_get values: &GetValues
nnearest: 3

_multi iteration filter: &multiIterationFilter
apply at iterations: 0,1,2,3,4,5
# ObsAnchors and ObsErrorAnchors are automatically prepended above this line
_iteration: &iterationConfig
geometry:
nml_file: ./namelist.atmosphere
streams_file: ./streams.atmosphere
deallocate non-da fields: true
interpolation type: unstructured
gradient norm reduction: 1e-3
_member: &memberConfig
date: &analysisDate '2024-05-27T00:00:00Z'
state variables: &incvars [spechum,surface_pressure,temperature,uReconstructMeridional,uReconstructZonal]
Expand All @@ -48,11 +10,23 @@ variational:
minimizer:
algorithm: DRPCG
iterations:
- <<: *iterationConfig
- geometry:
nml_file: ./namelist.atmosphere
streams_file: ./streams.atmosphere
deallocate non-da fields: true
interpolation type: unstructured
gradient norm reduction: 1e-3
diagnostics:
departures: ombg
ninner: 50
- <<: *iterationConfig
- geometry:
nml_file: ./namelist.atmosphere
streams_file: ./streams.atmosphere
deallocate non-da fields: true
interpolation type: unstructured
gradient norm reduction: 1e-3
diagnostics:
departures: ombg
ninner: 50
final:
diagnostics:
Expand All @@ -68,11 +42,11 @@ cost function:
streams_file: ./streams.atmosphere
deallocate non-da fields: true
interpolation type: unstructured
analysis variables: *incvars
analysis variables: *incvars
background:
state variables: [spechum,surface_pressure,temperature,uReconstructMeridional,uReconstructZonal,theta,rho,u,qv,pressure,landmask,xice,snowc,skintemp,ivgtyp,isltyp,snowh,vegfra,u10,v10,lai,smois,tslb,pressure_p,qc,qi,qg,qr,qs,cldfrac]
filename: data/restart.2024-05-27_00.00.00.nc
date: *analysisDate
filename: data/mpasout.2024-05-27_00.00.00.nc
date: *analysisDate
background error:
covariance model: ensemble
localization:
Expand All @@ -92,10 +66,10 @@ cost function:
members from template:
template:
<<: *memberConfig
filename: ./data/ens/mem%iMember%/restart.2024-05-27_00.00.00.nc
pattern: %iMember%
filename: ./data/ens/mem%iMember%/mpasout.2024-05-27_00.00.00.nc
pattern: "%iMember%"
start: 1
zero padding: 2
zero padding: 3
nmembers: 30
observations:
observers:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ geometry:
bump vunit: "modellevel" # modellevel, height
background:
state variables: &vars [spechum,surface_pressure,temperature,uReconstructMeridional,uReconstructZonal]
filename: "./data/restart.2024-05-27_00.00.00.nc"
filename: "./data/mpasout.2024-05-27_00.00.00.nc"
date: *validDate

background error:
Expand Down
6 changes: 3 additions & 3 deletions rrfs-test/testinput_expr/rrfs_mpasjedi_2024052700_getkf.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ background:
members from template:
template:
<<: *memberConfig
filename: ./data/ens/mem%iMember%/restart.2024-05-27_00.00.00.nc
pattern: %iMember%
filename: ./data/ens/mem%iMember%/mpasout.2024-05-27_00.00.00.nc
pattern: "%iMember%"
start: 1
zero padding: 2
zero padding: 3
nmembers: 30

observations:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ background:
members from template:
template:
<<: *memberConfig
filename: ./data/ens/mem%iMember%/restart.2024-05-27_00.00.00.nc
pattern: %iMember%
filename: ./data/ens/mem%iMember%/mpasout.2024-05-27_00.00.00.nc
pattern: "%iMember%"
start: 1
zero padding: 2
zero padding: 3
nmembers: 30

observations:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ background:
members from template:
template:
<<: *memberConfig
filename: ./data/ens/mem%iMember%/restart.2024-05-27_00.00.00.nc
pattern: %iMember%
filename: ./data/ens/mem%iMember%/mpasout.2024-05-27_00.00.00.nc
pattern: "%iMember%"
start: 1
zero padding: 2
zero padding: 3
nmembers: 30

observations:
Expand Down
6 changes: 3 additions & 3 deletions rrfs-test/testinput_expr/rrfs_mpasjedi_2024052700_letkf.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ background:
members from template:
template:
<<: *memberConfig
filename: ./data/ens/mem%iMember%/restart.2024-05-27_00.00.00.nc
pattern: %iMember%
filename: ./data/ens/mem%iMember%/mpasout.2024-05-27_00.00.00.nc
pattern: "%iMember%"
start: 1
zero padding: 2
zero padding: 3
nmembers: 30

observations:
Expand Down
6 changes: 3 additions & 3 deletions rrfs-test/testinput_expr/streams.atmosphere
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
<streams>
<immutable_stream name="static"
<immutable_stream name="invariant"
type="input"
precision="single"
filename_template="data/static.nc"
filename_template="data/invariant.nc"
io_type="pnetcdf,cdf5"
input_interval="initial_only" />

<immutable_stream name="input"
type="input"
precision="single"
filename_template="data/restart.2024-05-27_00.00.00.nc"
filename_template="data/mpasout.2024-05-27_00.00.00.nc"
io_type="pnetcdf,cdf5"
input_interval="initial_only" />

Expand Down
Loading
Loading