Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added test, renamed existing tests to F90, improved documentation #176

Merged
merged 4 commits into from
Feb 28, 2023
Merged

Added test, renamed existing tests to F90, improved documentation #176

merged 4 commits into from
Feb 28, 2023

Conversation

edwardhartnett
Copy link
Contributor

Part of #172
Part of #174
Part of #37

Added test, renamed existing tests to F90, improved documentation.

AlexanderRichert-NOAA
AlexanderRichert-NOAA approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@AlexanderRichert-NOAA AlexanderRichert-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Optionally you could (I think?) remove the "(200)" from those lines in r63w72.f. Built and ran tests on my personal machine.

@edwardhartnett edwardhartnett merged commit 922f772 into develop Feb 28, 2023
@edwardhartnett edwardhartnett deleted the ejh_t2 branch February 28, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderRichert-NOAA AlexanderRichert-NOAA AlexanderRichert-NOAA approved these changes

@Hang-Lei-NOAA Hang-Lei-NOAA Awaiting requested review from Hang-Lei-NOAA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edwardhartnett @AlexanderRichert-NOAA