Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fprettify test #232

Draft
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

AlexanderRichert-NOAA
Copy link
Contributor

This is a test of my fork of the fprettify Fortran 90 autoformatter.

@jbathegit
Copy link

Hi @AlexanderRichert-NOAA, per our discussion this morning during the Libraries Tag-Up, I took a look at your proposed "fprettify" changes, and most of them indeed align nicely with what I've already started doing in NCEPLIBS-bufr as I've been converting a number of those F77 routines to F90. Specifically, I've already been changing everything from uppercase to lowercase, and that matches what I see on your end. However, I've been continuing to only indent code blocks by 2 spaces instead of 4. Not sure how big a deal that difference in whitespace really is, but I wouldn't be opposed to changing that as well if we all decide to go this route.

@AlexanderRichert-NOAA
Copy link
Contributor Author

Thanks @jbathegit. I also like 2-space indentation so I'll give that a go here.

@edwardhartnett
Copy link
Contributor

4-space is what is used throughout the rest of NCEPLIBS and is the default for many editors...

@AlexanderRichert-NOAA
Copy link
Contributor Author

Yeah, I usually do two just to save space and avoid line continuations, but consistency across codes is the main goal here. I put it back to 4.

Another question: fprettify allows us to convert comparison operators to the classic Fortran style (.eq., .ne., .lt.,, .gt.) or "C" style (==, !=, <, >). Anyone have a preference? I don't really have a preference other than that consistency would be nice.

@jbathegit
Copy link

As a reminder, I've gone ahead and used the C-style comparison operators in NCEPLIBS-bufr re: #603

I personally like those better and think they're more readable, especially by folks more familiar with other languages (such as C :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants