Change hydrostatic_delz to delz #1284
Conversation
DavidNew-NOAA
requested review from
CoryMartin-NOAA,
RussTreadon-NOAA and
danholdaway
|
I'm rolling this PR into another one, so will close it. |
|
@danholdaway , if you have a chance would you take a look at this PR from @DavidNew-NOAA. We need the changes in this PR if we update the fv3-jedi hash. |
|
Testing of these changes along reported in jcb-gdas PR #27. Combination of these two PRs works! |
|
@DavidNew-NOAA, once jcb-gdas PR #27 is merged into jcb-gdas |
There was a problem hiding this comment.
jcb-gdas at 272d6d7 replaces hydrostatic_delz with delz. This is correct.
Approve.
|
@DavidNew-NOAA , the jcb-gdas hash has been updated in |
|
@RussTreadon-NOAA Looks good. Let's merge it |
|
Just catching up, sick kid. Is it safe to update the hash of just fv3-jedi and not other JEDI repos? |
|
@danholdaway I tested it in an experiment on Hera GW without a problem, though only one cycle. |
|
@danholdaway Also, the jjob tests passed for @RussTreadon-NOAA NOAA-EMC/jcb-gdas#27 (comment) |
This PR is a companion to FV3-JEDI PR #1263 and JCB-GDAS PR #27. It changes
hydrostatic_delztodelzin the FV3 increment fields metadata override file, along with the test input and reference file for one CTest. See the above referenced FV3-JEDI PR for motivation and other details.The gdasapp_fv3jedi_fv3inc CTest passes with these changes.