Completely remove wc_vert_int_chemoautopp #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andrew-c-ross , thanks. Code change looks good to me. I will also test it with NWA-RT for a sanity check. |
yichengt900
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
@andrew-c-ross, I can confirm that this PR completely removed wc_vert_int_chemoautopp and resolved the mysterious error in both 1D and NWA12-RT tests. Approved.
yichengt900
merged commit 24baf3b
into
NOAA-CEFI-Regional-Ocean-Modeling:dev/cefi
1 check passed
|
Hi @andrew-c-ross @yichengt900 - thank you for catching this. I am not sure how we missed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #76 by removing the four references to wc_vert_int_chemoautopp that were missed in #66 .