-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change COBALT bottom fluxes from 3d array to 2d #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At first I was surprised that this works, since the vertdiff routine uses %btf, but then I remembered vertdiff only gets applied to prognostic tracers and these are all diagnostic tracers, so this checks out 👍
The only side effect I can see is that enabling the bottom flux automatically creates potentially confusing diagnostics with names like "lithdet_btf_btf".
@andrew-c-ross, thank you. Regarding the side effects, perhaps we could consider renaming those diagnostics? For example, renaming |
I think it's fine to leave everything as is. The *_btf_btf diagnostic only appears if you look for it in the available_diags file. |
I looked at one of my older runs, for other variables that have a bottom flux, I don't see that bottom flux saved in the restarts (for example, I don't see no3_btf in the restarts). This could confirm Charlie's suspicion that the new diagnostic _btfs aren't being saved in the restarts. |
This reverts commit e44c059.
This PR resolves issue #38 by converting the COBALT bottom fluxes array from 3D to 2D, enhancing memory efficiency.
this PR is solely for code refactoring and does not alter the modeled results.