Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change COBALT bottom fluxes from 3d array to 2d #46

Merged
merged 4 commits into from
Apr 15, 2024
Merged

Conversation

yichengt900
Copy link
Collaborator

This PR resolves issue #38 by converting the COBALT bottom fluxes array from 3D to 2D, enhancing memory efficiency.
this PR is solely for code refactoring and does not alter the modeled results.

Copy link
Contributor

@andrew-c-ross andrew-c-ross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first I was surprised that this works, since the vertdiff routine uses %btf, but then I remembered vertdiff only gets applied to prognostic tracers and these are all diagnostic tracers, so this checks out 👍

The only side effect I can see is that enabling the bottom flux automatically creates potentially confusing diagnostics with names like "lithdet_btf_btf".

@yichengt900
Copy link
Collaborator Author

@andrew-c-ross, thank you. Regarding the side effects, perhaps we could consider renaming those diagnostics? For example, renaming cadet_arag_btf to b_cadet_arag to avoid confusion. What are your thoughts?

@andrew-c-ross
Copy link
Contributor

Regarding the side effects, perhaps we could consider renaming those diagnostics? For example, renaming cadet_arag_btf to b_cadet_arag to avoid confusion.

I think it's fine to leave everything as is. The *_btf_btf diagnostic only appears if you look for it in the available_diags file.

@yichengt900 yichengt900 merged commit e44c059 into dev/cefi Apr 15, 2024
1 check passed
@yichengt900 yichengt900 deleted the 3d_2_2d_btf branch April 15, 2024 19:35
@andrew-c-ross
Copy link
Contributor

I looked at one of my older runs, for other variables that have a bottom flux, I don't see that bottom flux saved in the restarts (for example, I don't see no3_btf in the restarts). This could confirm Charlie's suspicion that the new diagnostic _btfs aren't being saved in the restarts.

yichengt900 added a commit that referenced this pull request Apr 16, 2024
yichengt900 added a commit that referenced this pull request Apr 16, 2024
This reverts commit e44c059. We will reconsider `3d bottom flux ->2d` change once we have a better idea of its impact on the restart file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants