Cleanup: float index and unused variables #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yichengt900
assigned andrew-c-ross, amoebaliz, gabyneg, charliestock, theresa-morrison and yichengt900
|
Thanks, @andrew-c-ross. Although some of the changes, like tab removal, might be overwritten by #23, they all look good to me. I will keep this PR open for a while to give others a chance to review it |
|
Sounds good 👍 It's all extremely picky details that won't change anything, so there's no urgency |
yichengt900
approved these changes
Apr 5, 2024
yichengt900
merged commit 9f49bda
into
NOAA-CEFI-Regional-Ocean-Modeling:dev/cefi
1 check passed
|
Thanks for catching these Andrew, Yi-Cheng. It is good to catch these whether they are small or not! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started this PR to fix the extremely minor issue of using a float as an index (mentioned in #29). While I was at it, though, I also cleaned up some other extremely minor issues reported by compiling with -Wall (some unused variables and all instances of tabs). None of these should have any effect on the actual model. There's a chance the unused variables indicate something that is unintentionally not included in the current source, though.