cleaned up plankton foodweb code (#67)

* cleaned up plankton foodweb code * Update generic_COBALT.F90 Added missing closing quotation mark --------- Co-authored-by: Yi-Cheng Teng - NOAA GFDL <[email protected]>
NOAA-CEFI-Regional-Ocean-Modeling · Jun 11, 2024 · 3c6288c · 3c6288c
1 parent 6cb8800
commit 3c6288c
Show file tree

Hide file tree

Showing 4 changed files with 107 additions and 202 deletions.
diff --git a/generic_tracers/cobalt_reg_diag.F90 b/generic_tracers/cobalt_reg_diag.F90
@@ -1802,10 +1802,6 @@ subroutine cobalt_reg_diagnostics(diag_list,axes,init_time,phyto,zoo,bact,cobalt
     cobalt%id_sfc_irr_aclm = register_diag_field(package_name, vardesc_temp%name, axes(1:2),&
          init_time, vardesc_temp%longname,vardesc_temp%units, missing_value = missing_value1)
 
-    vardesc_temp = vardesc("sfc_irr_mem_dp","Surface Irradiance memory, diapause",'h','1','s','W m-2','f')
-    cobalt%id_sfc_irr_mem_dp = register_diag_field(package_name, vardesc_temp%name, axes(1:2),&
-         init_time, vardesc_temp%longname,vardesc_temp%units, missing_value = missing_value1)
-
     vardesc_temp = vardesc("sfc_temp","Surface Temperature",'h','1','s','deg C','f')
     cobalt%id_sfc_temp = register_diag_field(package_name, vardesc_temp%name, axes(1:2),&
          init_time, vardesc_temp%longname,vardesc_temp%units, missing_value = missing_value1)
@@ -2347,10 +2343,6 @@ subroutine cobalt_reg_diagnostics(diag_list,axes,init_time,phyto,zoo,bact,cobalt
     cobalt%id_jprod_mesozoo_200 = register_diag_field(package_name, vardesc_temp%name, axes(1:2),&
          init_time, vardesc_temp%longname,vardesc_temp%units, missing_value = missing_value1)
 
-    vardesc_temp = vardesc("dp_fac","diapause factor",'h','1','s','none','f')
-    cobalt%id_dp_fac = register_diag_field(package_name, vardesc_temp%name, axes(1:2),&
-         init_time, vardesc_temp%longname,vardesc_temp%units, missing_value = missing_value1)
-
     vardesc_temp = vardesc("daylength","daylength",'h','1','s','hours','f')
     cobalt%id_daylength = register_diag_field(package_name, vardesc_temp%name, axes(1:2),&
          init_time, vardesc_temp%longname,vardesc_temp%units, missing_value = missing_value1)

diff --git a/generic_tracers/cobalt_send_diag.F90 b/generic_tracers/cobalt_send_diag.F90
@@ -720,9 +720,6 @@ subroutine cobalt_send_diagnostics(model_time,grid_tmask,Temp,rho_dzt,dzt,&
        used = g_send_data(cobalt%id_sfc_irr_aclm,  cobalt%f_irr_aclm_sfc(:,:,1),       &
        model_time, rmask = grid_tmask(:,:,1),&
        is_in=isc, js_in=jsc,ie_in=iec, je_in=jec)
-       used = g_send_data(cobalt%id_sfc_irr_mem_dp,  cobalt%f_irr_mem_dp(:,:,1),       &
-       model_time, rmask = grid_tmask(:,:,1),&
-       is_in=isc, js_in=jsc,ie_in=iec, je_in=jec)
        used = g_send_data(cobalt%id_mld_aclm,  cobalt%mld_aclm,       &
        model_time, rmask = grid_tmask(:,:,1),&
        is_in=isc, js_in=jsc,ie_in=iec, je_in=jec)
@@ -1055,9 +1052,6 @@ subroutine cobalt_send_diagnostics(model_time,grid_tmask,Temp,rho_dzt,dzt,&
         used = g_send_data(cobalt%id_jprod_mesozoo_200, cobalt%jprod_mesozoo_200,         &
         model_time, rmask = grid_tmask(:,:,1),&
         is_in=isc, js_in=jsc, ie_in=iec, je_in=jec)
-        used = g_send_data(cobalt%id_dp_fac, cobalt%dp_fac,         &
-        model_time, rmask = grid_tmask(:,:,1),&
-        is_in=isc, js_in=jsc, ie_in=iec, je_in=jec)
         used = g_send_data(cobalt%id_daylength, cobalt%daylength,         &
         model_time, rmask = grid_tmask(:,:,1),&
         is_in=isc, js_in=jsc, ie_in=iec, je_in=jec)

diff --git a/generic_tracers/cobalt_types.F90 b/generic_tracers/cobalt_types.F90
@@ -456,11 +456,7 @@ module cobalt_types
           case2_salt,       & ! salt threshold for case 2 (coastal) waters
           case2_opac_add,   & ! added opacity for case 2 (coastal) waters
           min_daylength,    &
-          gamma_irr_mem_dp, &
           gamma_mu_mem,     &
-          irr_mem_dpthresh1, &
-          irr_mem_dpthresh2, &
-          dpause_max,       &
           gamma_ndet,       &
           gamma_nitrif,     &
           k_nh3_nitrif,     &
@@ -588,7 +584,6 @@ module cobalt_types
           f_irr_aclm,&
           f_irr_aclm_z,&
           f_irr_aclm_sfc, &
-          f_irr_mem_dp,&
           f_cased,&
           f_cadet_arag_btf,&
           f_cadet_calc_btf,&
@@ -846,7 +841,6 @@ module cobalt_types
           z_o2min, &
           z_sat_arag,&
           z_sat_calc,&
-          dp_fac,&
           daylength,&
 !==============================================================================================================
 ! JGJ 2016/08/08 CMIP6 Ocnbgc
@@ -1112,7 +1106,6 @@ module cobalt_types
           id_sfc_chl       = -1,       &
           id_sfc_irr       = -1,       &
           id_sfc_irr_aclm   = -1,       &
-          id_sfc_irr_mem_dp = -1,      &
           id_sfc_temp      = -1,       &
           id_btm_temp      = -1,       &
           id_btm_temp_old  = -1,       &
@@ -1204,7 +1197,6 @@ module cobalt_types
           id_jprod_cadet_calc_100 = -1, &
           id_jprod_cadet_arag_100 = -1, &
           id_jprod_mesozoo_200 = -1,   &
-          id_dp_fac            = -1,   &
           id_daylength         = -1,   &
           id_jremin_ndet_100 = -1,     &
           id_f_ndet_100 = -1,          &