Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: [AEA-4047] - Set statuses to temporarily unavailable if nppts fails #1024

Conversation

originalphil
Copy link
Contributor

@originalphil originalphil commented Jun 25, 2024

Summary

  • Routine Change

Details

No longer use catch all error for nppts call. Always progress to enrich prescriptions. Update items expecting status updates with temporary message.

Copy link
Contributor

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

@originalphil originalphil changed the title Fix: [AEA-4047] - Set statuses to temporarily unavailable if nppts fails DO NOT MERGE Fix: [AEA-4047] - Set statuses to temporarily unavailable if nppts fails Jun 25, 2024
@@ -116,11 +122,15 @@ describe("Unit tests for statusUpdate, via handler", function () {
jest.useFakeTimers()
})

it("when event is processed, statusUpdateData is included in the response", async () => {
it.skip("when event is processed, statusUpdateData is included in the response", async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be skipped?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should not. Well spotted!

@MatthewPopat-NHS MatthewPopat-NHS enabled auto-merge (squash) July 11, 2024 14:39
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants