Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCM-7498: add playwright test suite for templates api #262

Merged
merged 18 commits into from
Jan 27, 2025

Conversation

harrim91
Copy link
Contributor

@harrim91 harrim91 commented Jan 14, 2025

Description

  • Adds E2E playwright test suite for templates API that runs in CI pipeline
  • Adds API Gateway access logging to API
  • Fixes authorizer caching bug - now just use the auth token as the cache key, and return a policy granting access to all API endpoints
  • Fix issue where newly created templates had different created and updated timestamps
  • Update error message to be clearer when trying to edit a submitted template

Context

We had no E2E tests for the backend API

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

bhansell1
bhansell1 previously approved these changes Jan 15, 2025
@harrim91 harrim91 enabled auto-merge January 27, 2025 12:00
@harrim91 harrim91 merged commit b25ca3e into main Jan 27, 2025
28 checks passed
@harrim91 harrim91 deleted the feature/CCM-7498_templates-api-test-pack branch January 27, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants