Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase banner quick fix #25

Merged
merged 5 commits into from
Dec 13, 2024
Merged

Phase banner quick fix #25

merged 5 commits into from
Dec 13, 2024

Conversation

jakecosgrove
Copy link

Description

Removed additional phase banners from Ross' test

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@jakecosgrove jakecosgrove requested a review from a team as a code owner December 13, 2024 11:05
Copy link

@emmagifford emmagifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve this PR. Checked the following changes:

  • developer phase banner added to dev preview of website - looks good, and the link to our live site works fine
  • new MESH guidance link added (to open in new tab) - works fine
  • PDS response date of birth does not match given date of birth' removed from /message-and-channel-status
  • PDS H3 subheading correctly fixed to become a H2 in /personalisation
  • 'NHS Notify' added to API and MESH subheadings in /personalisation
  • 'dateOfBirth' typo removed from the column name example in /personalisation

@jakecosgrove jakecosgrove merged commit c80fe0a into main Dec 13, 2024
37 checks passed
@jakecosgrove jakecosgrove deleted the Phase-banner-quick-fix branch December 18, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants