APPT-603: Remove inflight package #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsed-nhs
approved these changes
Jan 31, 2025
sambiramairelogic
force-pushed
the
APPT-603/memory-leak
branch
from
9f27604 to
67d03e6
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A memory leak has been found in the NextJS web app server. We think this is caused by the inflight package, which is a dependency of glob, which is a dependency of Jest's latest version.
Later versions of glob have replaced this dangerous dependency, but the latest version of Jest still uses the older versions of glob which include it. Frustrating, this still hasn't been fixed in the alpha version of jest@next.
This PR overrides the glob version requested by jest with the later version which does not include the inflight package.
It also removes several linting errors that have been committed to main.