Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appt 565/okta integration #454

Merged
merged 17 commits into from
Jan 30, 2025
Merged

Appt 565/okta integration #454

merged 17 commits into from
Jan 30, 2025

Conversation

MikeHDigital
Copy link
Contributor

@MikeHDigital MikeHDigital commented Jan 23, 2025

This change adds Okta authentication as an option for user login.

mya-login

There is a test user set up in the okta organisation, credentials for that will be available in confluence to facilitate testing of this change, however this will need actioning in whatever new development and test organisations that will be set up. Details around the accounts and organisation setup for the deployment to environments are still to be determined.

NHS Mail should continue to work but as yet only been able to test with the dummy oidc locally.

Significant change in this PR would be to the shape of the configuration elements around auth. As there are now multiple auth providers that need their own validation parameters and urls settting up I have altered the configuration structure to facilitate this.

Obviously that will be a breaking change if the configuration for the environments isn't amended before releasing this change set. The intention would be to add this new configuration shape to the environments in addition to the existing configuration before this is released, and then the old configuration shape can be removed once this release has stabilised.

@MikeHDigital
Copy link
Contributor Author

MikeHDigital commented Jan 23, 2025

I think if everyone is going to run this as it stands we will run into rate limit issues pulling the jwks especially if people iterate a lot by restarting the api.

I will add some tests that simulate the failure I'm expecting and see what we can do to mitigate the failure to allow the local oidc to keep working in the event of us breaching the rate limits set by okta.

I guess an easy enough work around will be to pull the okta config or have developers get their own okta trial account for local dev in lieu of a more "real" NHS okta org.

Okta now configured with staging environment and tested locally. Getting onto the pipeline and variable work.

Copy link
Contributor

@vicr1 vicr1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional work is needed to the deployment pipeline to make sure that configuration for the deployed application is correct. As it stands this will not work if deployed as the env vars will not be setup correctly.

vicr1
vicr1 previously approved these changes Jan 29, 2025
@MikeHDigital MikeHDigital merged commit c1a6f19 into main Jan 30, 2025
3 checks passed
@MikeHDigital MikeHDigital deleted the APPT-565/okta-integration branch January 30, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants