-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Appt 565/okta integration #454
Conversation
Okta now configured with staging environment and tested locally. Getting onto the pipeline and variable work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional work is needed to the deployment pipeline to make sure that configuration for the deployed application is correct. As it stands this will not work if deployed as the env vars will not be setup correctly.
…ital/nbs-appointments-management-service into APPT-565/okta-integration
…-management-service into APPT-565/okta-integration
Quality Gate passedIssues Measures |
This change adds Okta authentication as an option for user login.
There is a test user set up in the okta organisation, credentials for that will be available in confluence to facilitate testing of this change,
however this will need actioning in whatever new development and test organisations that will be set up. Details around the accounts and organisation setup for the deployment to environments are still to be determined.NHS Mail should continue to work but as yet only been able to test with the dummy oidc locally.
Significant change in this PR would be to the shape of the configuration elements around auth. As there are now multiple auth providers that need their own validation parameters and urls settting up I have altered the configuration structure to facilitate this.
Obviously that will be a breaking change if the configuration for the environments isn't amended before releasing this change set. The intention would be to add this new configuration shape to the environments in addition to the existing configuration before this is released, and then the old configuration shape can be removed once this release has stabilised.